backlight: arcxcnn: Use backlight helper
Subsystems (2)
PATCH RESEND 2/4 backlight: arcxcnn: Use backlight helper
Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes.
--- drivers/video/backlight/arcxcnn_bl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/video/backlight/arcxcnn_bl.c +1 -4
@@ -130,12 +130,9 @@ static int arcxcnn_set_brightness(struct arcxcnn *lp, u32 brightness)static int arcxcnn_bl_update_status (struct backlight_device *bl) {struct arcxcnn *lp =bl_get_data (bl); -u32 brightness = bl->props.brightness; +u32 brightness =backlight_get_brightness (bl);int ret; -if (bl->props.state & (BL_CORE_SUSPENDED |BL_CORE_FBBLANK )) - brightness =0 ; - ret =arcxcnn_set_brightness (lp, brightness);if (ret)return ret;
Signature · 1 line
2.30.2
Quoted 6 lines · Stephen Kitt
Instead of retrieving the backlight brightness in struct
backlight_propertiesmanually, and then checking whether the backlight should be on at all, usebacklight_get_brightness()which does all this and insulates this from future changes.Signed-off-by Stephen Kitt <[email protected]>
Quoted 24 lines
--- drivers/video/backlight/arcxcnn_bl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/video/backlight/arcxcnn_bl.c +1
-4@@ -130,12 +130,9 @@ static int arcxcnn_set_brightness(struct arcxcnn *lp, u32 brightness)static int arcxcnn_bl_update_status (struct backlight_device *bl) {struct arcxcnn *lp =bl_get_data (bl); -u32 brightness = bl->props.brightness; +u32 brightness =backlight_get_brightness (bl);int ret; -if (bl->props.state & (BL_CORE_SUSPENDED |BL_CORE_FBBLANK )) - brightness =0 ; - ret =arcxcnn_set_brightness (lp, brightness);if (ret)return ret;Signature · 1 line
2.30.2
Quoted 6 lines · Stephen Kitt
Instead of retrieving the backlight brightness in struct
backlight_propertiesmanually, and then checking whether the backlight should be on at all, usebacklight_get_brightness()which does all this and insulates this from future changes.Signed-off-by Stephen Kitt <[email protected]>
For the tools:
D.
Quoted 9 lines · Stephen Kitt
Instead of retrieving the backlight brightness in struct
backlight_propertiesmanually, and then checking whether the backlight should be on at all, usebacklight_get_brightness()which does all this and insulates this from future changes.Signed-off-by Stephen Kitt <[email protected]>--- drivers/video/backlight/arcxcnn_bl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
Applied, thanks
Signature · 1 line
Lee Jones [李琼斯]