mfd: arizona: Use pm_runtime_resume_and_get() to prevent refcnt leak
Subsystems (2)
PATCH v2 1/1 mfd: arizona: Use pm_runtime_resume_and_get() to prevent refcnt leak
In arizona_clk32k_enable(), we should use pm_runtime_resume_and_get() as pm_runtime_get_sync() will increase the refcnt even when it returns an error.
Signed-off-by Liang He <[email protected]>
---
changelog:
v1: add missing pm_runtime_put_sync()
v2: use pm_runtime_resume_and_get()
drivers/mfd/arizona-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/arizona-core.c +1 -1
@@ -45,7 +45,7 @@ int arizona_clk32k_enable(struct arizona *arizona)if (arizona->clk32k_ref ==1 ) {switch (arizona->pdata.clk32k_src) {case ARIZONA_32KZ_MCLK1 : - ret =pm_runtime_get_sync (arizona->dev); + ret =pm_runtime_resume_and_get (arizona->dev);if (ret !=0 ) goto err_ref; ret =clk_prepare_enable (arizona->mclk[ARIZONA_MCLK1 ]);
Signature · 1 line
2.25.1
Quoted 6 lines · Liang He
In
arizona_clk32k_enable(), we should usepm_runtime_resume_and_get()aspm_runtime_get_sync()will increase the refcnt even when it returns an error.Signed-off-by Liang He <[email protected]>---
Acked-by Charles Keepax <[email protected]>
Thanks,
Charles
Quoted 4 lines · Liang He
In
arizona_clk32k_enable(), we should usepm_runtime_resume_and_get()aspm_runtime_get_sync()will increase the refcnt even when it returns an error.
Quoted 8 lines
Signed-off-by Liang He <[email protected]>---
changelog:
v1: add missingpm_runtime_put_sync()
v2: usepm_runtime_resume_and_get()drivers/mfd/arizona-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Signature · 1 line
Lee Jones [李琼斯]