Skip to contentSkip to conversation

Input: st-keyscan - Use devm_platform_get_and_ioremap_resource()

PATCH Applied [email protected] 3 participants 3 messages Jan 28, 2023 – Jan 30, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: st-keyscan - Use devm_platform_get_and_ioremap_resource()

From: ye xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

---
 drivers/input/keyboard/st-keyscan.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/input/keyboard/st-keyscan.c +1 -3
index 13735a5e8391..b6e83324f97a 100644
@@ -125,7 +125,6 @@ static int keyscan_probe(struct platform_device *pdev)
 {
 	struct st_keyscan *keypad_data;
 	struct input_dev *input_dev;
-	struct resource *res;
 	int error;
 
 	if (!pdev->dev.of_node) {
@@ -169,8 +168,7 @@ static int keyscan_probe(struct platform_device *pdev)
 
 	input_set_drvdata(input_dev, keypad_data);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	keypad_data->base = devm_ioremap_resource(&pdev->dev, res);
+	keypad_data->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
 	if (IS_ERR(keypad_data->base))
 		return PTR_ERR(keypad_data->base);
 
Signature · 1 line
2.25.1
#2 lore raw
In reply to [email protected]
Quoted 5 lines · On Sat, Jan 28, 2023 at 04:11:30PM +0800, [email protected] wrote:

From: ye xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

...

drivers/input/keyboard/st-keyscan.c static int keyscan_probe(struct platform_device *pdev) · line 171

Quoted 3 lines
drivers/input/keyboard/st-keyscan.c +1 -2
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	keypad_data->base = devm_ioremap_resource(&pdev->dev, res);
+	keypad_data->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

Why?

What we need here is simple devm_platform_ioremap_resource().

Signature · 2 lines
With Best Regards,
Andy Shevchenko