udf: remove reporting loc in debug output
PATCH 1/1 udf: remove reporting loc in debug output
clang build fails withfs/udf/partition.c:86:28: error: variable 'loc' is uninitialized when used here [-Werror,-Wuninitialized]
sb, block, partition, loc, index);
^~~loc is now only know when bh is valid. So remove reporting loc in debug output.
--- fs/udf/partition.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/udf/partition.c +2 -2
@@ -82,8 +82,8 @@ uint32_t udf_get_pblock_virt15(struct super_block *sb, uint32_t block, bh =udf_bread (sbi->s_vat_inode, newblock,0 , &err);if (!bh) { -udf_debug ("get_pblock(UDF_VIRTUAL_MAP:%p,%u,%u) VAT: %u[%u]\n" , - sb, block, partition, loc, index); +udf_debug ("get_pblock(UDF_VIRTUAL_MAP:%p,%u,%u)\n" , + sb, block, partition);return 0xFFFFFFFF ; }
Signature · 1 line
2.26.3
Quoted 9 lines · Tom Rix
clang build fails with
fs/udf/partition.c:86:28: error: variable 'loc' is uninitialized when used here [-Werror,-Wuninitialized]sb, block, partition, loc, index); ^~~loc is now only know when bh is valid. So remove reporting loc in debug output.
Fixes 4215db46d538 ("udf: Use udf_bread() in udf_get_pblock_virt15()")Signed-off-by Tom Rix <[email protected]>
Quoted 22 lines
--- fs/udf/partition.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/udf/partition.c +2
-2@@ -82,8 +82,8 @@ uint32_t udf_get_pblock_virt15(struct super_block *sb, uint32_t block, bh =udf_bread (sbi->s_vat_inode, newblock,0 , &err);if (!bh) { -udf_debug ("get_pblock(UDF_VIRTUAL_MAP:%p,%u,%u) VAT: %u[%u]\n" , - sb, block, partition, loc, index); +udf_debug ("get_pblock(UDF_VIRTUAL_MAP:%p,%u,%u)\n" , + sb, block, partition);return 0xFFFFFFFF ; }Signature · 1 line
2.26.3
Quoted 6 lines · Tom Rix
clang build fails with
fs/udf/partition.c:86:28: error: variable 'loc' is uninitialized when used here [-Werror,-Wuninitialized]sb, block, partition, loc, index); ^~~loc is now only know when bh is valid. So remove reporting loc in debug output.
typo: s/know/known/
Quoted 3 lines
Fixes 4215db46d538 ("udf: Use udf_bread() in udf_get_pblock_virt15()")Signed-off-by Tom Rix <[email protected]>
Thanks Tom, kernelci has also been reporting this.
https://lore.kernel.org/linux-next/?q=error%3A+variable+%27loc%27+is+uninitialized+when+used+here
Quoted 23 lines
--- fs/udf/partition.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/udf/partition.c +2
-2@@ -82,8 +82,8 @@ uint32_t udf_get_pblock_virt15(struct super_block *sb, uint32_t block, bh =udf_bread (sbi->s_vat_inode, newblock,0 , &err);if (!bh) { -udf_debug ("get_pblock(UDF_VIRTUAL_MAP:%p,%u,%u) VAT: %u[%u]\n" , - sb, block, partition, loc, index); +udf_debug ("get_pblock(UDF_VIRTUAL_MAP:%p,%u,%u)\n" , + sb, block, partition);return 0xFFFFFFFF ; }Signature · 1 line
2.26.3
Quoted 9 lines · Tom Rix
clang build fails with
fs/udf/partition.c:86:28: error: variable 'loc' is uninitialized when used here [-Werror,-Wuninitialized]sb, block, partition, loc, index); ^~~loc is now only know when bh is valid. So remove reporting loc in debug output.
Fixes 4215db46d538 ("udf: Use udf_bread() in udf_get_pblock_virt15()")Signed-off-by Tom Rix <[email protected]>
Thanks! Patch applied!
Honza
Quoted 22 lines
--- fs/udf/partition.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/udf/partition.c +2
-2@@ -82,8 +82,8 @@ uint32_t udf_get_pblock_virt15(struct super_block *sb, uint32_t block, bh =udf_bread (sbi->s_vat_inode, newblock,0 , &err);if (!bh) { -udf_debug ("get_pblock(UDF_VIRTUAL_MAP:%p,%u,%u) VAT: %u[%u]\n" , - sb, block, partition, loc, index); +udf_debug ("get_pblock(UDF_VIRTUAL_MAP:%p,%u,%u)\n" , + sb, block, partition);return 0xFFFFFFFF ; }Signature · 1 line
2.26.3
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR