Skip to contentSkip to conversation

media: atomisp: Remove unused header

PATCH In review Andy Shevchenko 2 participants 5 messages Jan 22, 2021 – Feb 11, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: atomisp: Remove unused header

sfi.h is not anyhow used by the driver. Remove it.

---
 drivers/staging/media/atomisp/include/linux/atomisp_platform.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/media/atomisp/include/linux/atomisp_platform.h +0 -1
index 5a5121d958ed..8c65733e0255 100644
@@ -22,7 +22,6 @@
 #include <asm/processor.h>
 
 #include <linux/i2c.h>
-#include <linux/sfi.h>
 #include <media/v4l2-subdev.h>
 #include "atomisp.h"
 
Signature · 1 line
2.29.2
#1 lore raw
Quoted 1 line · Andy Shevchenko

sfi.h is not anyhow used by the driver. Remove it.

Mauro, can you give your Ack to be able to merge this via other tree?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
In reply to Andy Shevchenko
Quoted 1 line · Andy Shevchenko

sfi.h is not anyhow used by the driver. Remove it.

Mario, Sakari, any comments on this?
Can you give your Ack to get this thru another tree?

Quoted 21 lines
---
 drivers/staging/media/atomisp/include/linux/atomisp_platform.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/media/atomisp/include/linux/atomisp_platform.h +0 -1
index 5a5121d958ed..8c65733e0255 100644
@@ -22,7 +22,6 @@
 #include <asm/processor.h>
 
 #include <linux/i2c.h>
-#include <linux/sfi.h>
 #include <media/v4l2-subdev.h>
 #include "atomisp.h"
 
Signature · 1 line
2.29.2
Signature · 2 lines
With Best Regards,
Andy Shevchenko
reviewer Acked-by
#3 lore raw

Hi Andy,

Quoted 5 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko

sfi.h is not anyhow used by the driver. Remove it.

Mario, Sakari, any comments on this?
Can you give your Ack to get this thru another tree?

Feel free to go ahead on my behalf; I see no issue with that.

Quoted 28 lines
Quoted 22 lines
---
 drivers/staging/media/atomisp/include/linux/atomisp_platform.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/media/atomisp/include/linux/atomisp_platform.h +0 -1
index 5a5121d958ed..8c65733e0255 100644
@@ -22,7 +22,6 @@
 #include <asm/processor.h>
 
 #include <linux/i2c.h>
-#include <linux/sfi.h>
 #include <media/v4l2-subdev.h>
 #include "atomisp.h"
 
Signature · 1 line
2.29.2
Signature · 2 lines
With Best Regards,
Andy Shevchenko
Signature · 3 lines
Kind regards,

Sakari Ailus
#4 lore raw
Quoted 4 lines · Sakari Ailus

Hi Andy,

Quoted 1 line · Andy Shevchenko

On Fri, Jan 22, 2021 at 02:33:03PM +0200, Andy Shevchenko wrote:

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

sfi.h is not anyhow used by the driver. Remove it.

Mario, Sakari, any comments on this?
Can you give your Ack to get this thru another tree?

Feel free to go ahead on my behalf; I see no issue with that.

Thank you, Sakari!

Signature · 2 lines
With Best Regards,
Andy Shevchenko