compiler.h: Raise minimum version of GCC to 5.1 for arm64
PATCH v2 1/1 compiler.h: Raise minimum version of GCC to 5.1 for arm64
commit dca5244d2f5b94f1809f0c02a549edf41ccd5493 upstream.
GCC versions >= 4.9 and < 5.1 have been shown to emit memory references beyond the stack pointer, resulting in memory corruption if an interrupt is taken after the stack pointer has been adjusted but before the reference has been executed. This leads to subtle, infrequent data corruption such as the EXT4 problems reported by Russell King at the link below.
Life is too short for buggy compilers, so raise the minimum GCC version required by arm64 to 5.1.
--- include/linux/compiler-gcc.h | 6 ++++++ 1 file changed, 6 insertions(+)
include/linux/compiler-gcc.h +6 -0
@@ -145,6 +145,12 @@#if GCC_VERSION <30200 # error Sorry, your compiler is too old - please upgrade it. +#elif defined(CONFIG_ARM64 ) &&GCC_VERSION <50100 && !defined(__clang__) +/* +* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 +* https://lore.kernel.org/r/[email protected] +*/ +# error Sorry, your version of GCC is too old - please use 5.1 or newer.#endif #if GCC_VERSION <30300
Signature · 1 line
2.30.0.280.ga3ce27912f-goog
Greg KH
maintainerQuoted 32 lines · Will Deacon
commit
dca5244d2f5b94f1809f0c02a549edf41ccd5493upstream.GCC versions >= 4.9 and < 5.1 have been shown to emit memory references beyond the stack pointer, resulting in memory corruption if an interrupt is taken after the stack pointer has been adjusted but before the reference has been executed. This leads to subtle, infrequent data corruption such as the EXT4 problems reported by Russell King at the link below.
Life is too short for buggy compilers, so raise the minimum GCC version required by arm64 to 5.1.
Reported-by Russell King <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Signed-off-by Will Deacon <[email protected]>Tested-by Nathan Chancellor <[email protected]>Reviewed-by Nick Desaulniers <[email protected]>Reviewed-by Nathan Chancellor <[email protected]>Acked-by Linus Torvalds <[email protected]>Cc <[email protected]> # 4.4.y, 4.9.y and 4.14.y onlyCc Theodore Ts'o <[email protected]>Cc Florian Weimer <[email protected]>Cc Peter Zijlstra <[email protected]>Cc Nick Desaulniers <[email protected]>Cc Nathan Chancellor <[email protected]>Cc Naresh Kamboju <[email protected]>Signed-off-by Catalin Marinas <[email protected]>[will: backport to 4.4.y/4.9.y/4.14.y; add __clang__ check]Link https://lore.kernel.org/r/CA+G9fYuzE9WMSB7uGjV4gTzK510SHEdJb_UXQCzsQ5MqA=h9SA@mail.gmail.com open hereSigned-off-by Will Deacon <[email protected]>
Quoted 3 lines
--- include/linux/compiler-gcc.h | 6 ++++++ 1 file changed, 6 insertions(+)
Thanks, now queued up, let's try this again :)
greg k-h
Quoted 24 lines · Greg KH
Quoted 22 lines · Will Deacon
commit
dca5244d2f5b94f1809f0c02a549edf41ccd5493upstream.GCC versions >= 4.9 and < 5.1 have been shown to emit memory references beyond the stack pointer, resulting in memory corruption if an interrupt is taken after the stack pointer has been adjusted but before the reference has been executed. This leads to subtle, infrequent data corruption such as the EXT4 problems reported by Russell King at the link below.
Life is too short for buggy compilers, so raise the minimum GCC version required by arm64 to 5.1.
Reported-by Russell King <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Signed-off-by Will Deacon <[email protected]>Tested-by Nathan Chancellor <[email protected]>Reviewed-by Nick Desaulniers <[email protected]>Reviewed-by Nathan Chancellor <[email protected]>Acked-by Linus Torvalds <[email protected]>Cc <[email protected]> # 4.4.y, 4.9.y and 4.14.y onlyCc Theodore Ts'o <[email protected]>Cc Florian Weimer <[email protected]>
Quoted 8 lines
Quoted 8 lines
Cc Peter Zijlstra <[email protected]>Cc Nick Desaulniers <[email protected]>Cc Nathan Chancellor <[email protected]>Cc Naresh Kamboju <[email protected]>Signed-off-by Catalin Marinas <[email protected]>[will: backport to 4.4.y/4.9.y/4.14.y; add __clang__ check]
LGTM
Quoted 9 lines
Quoted 5 lines
Link https://lore.kernel.org/r/CA+G9fYuzE9WMSB7uGjV4gTzK510SHEdJb_UXQCzsQ5MqA=h9SA@mail.gmail.com open hereSigned-off-by Will Deacon <[email protected]>--- include/linux/compiler-gcc.h | 6 ++++++ 1 file changed, 6 insertions(+)Thanks, now queued up, let's try this again :)
greg k-h
Signature · 2 lines
Thanks, ~Nick Desaulniers