ipa: add remoteproc dependency
Subsystems (3)
PATCH 1/1 ipa: add remoteproc dependency
From: Arnd Bergmann <[email protected]>
Compile-testing without CONFIG_REMOTEPROC results in a build failure:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
ipa_main.c
net/ipa/ipa_main.o:(ipa_probe) in archivedrivers/built-in.a
ld.lld: error: undefined symbol: rproc_put
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
referenced by
ipa_main.c
net/ipa/ipa_main.o:(ipa_probe) in archivedrivers/built-in.a
referenced byipa_main.c
net/ipa/ipa_main.o:(ipa_remove) in archivedrivers/built-in.a
Add a new dependency to avoid this.
--- drivers/net/ipa/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/net/ipa/Kconfig +1 -0
@@ -3,6 +3,7 @@ config QCOM_IPA depends on 64BIT && NET && QCOM_SMEM depends on ARCH_QCOM || COMPILE_TEST depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) + depends on REMOTEPROC select QCOM_MDT_LOADER if ARCH_QCOM select QCOM_QMI_HELPERS help
Signature · 1 line
2.29.2
Quoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Compile-testing without
CONFIG_REMOTEPROCresults in a build failure:Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
ipa_main.c
net/ipa/ipa_main.o:(ipa_probe) in archivedrivers/built-in.a
Quoted 8 lines
ld.lld: error: undefined symbol:
rproc_putQuoted 4 lines
Quoted 4 lines
Quoted 4 lines
referenced by
ipa_main.c
net/ipa/ipa_main.o:(ipa_probe) in archivedrivers/built-in.a
referenced byipa_main.c
net/ipa/ipa_main.o:(ipa_remove) in archivedrivers/built-in.aAdd a new dependency to avoid this.
Afaict this should be addressed by:
86fdf1fc60e9 ("net: ipa: remove a remoteproc dependency")
which is present in linux-next.
Regards,
Bjorn
Quoted 21 lines
Fixes 38a4066f593c ("net: ipa: support COMPILE_TEST")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/net/ipa/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/net/ipa/Kconfig +1
-0@@ -3,6 +3,7 @@ config QCOM_IPA depends on 64BIT && NET && QCOM_SMEM depends on ARCH_QCOM || COMPILE_TEST depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) + depends on REMOTEPROC select QCOM_MDT_LOADER if ARCH_QCOM select QCOM_QMI_HELPERS helpSignature · 1 line
2.29.2
Quoted 15 lines · Bjorn Andersson
Quoted 12 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Compile-testing without
CONFIG_REMOTEPROCresults in a build failure:Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
ipa_main.c
net/ipa/ipa_main.o:(ipa_probe) in archivedrivers/built-in.ald.lld: error: undefined symbol:
rproc_putQuoted 4 lines
Quoted 4 lines
Quoted 4 lines
referenced by
ipa_main.c
net/ipa/ipa_main.o:(ipa_probe) in archivedrivers/built-in.a
referenced byipa_main.c
net/ipa/ipa_main.o:(ipa_remove) in archivedrivers/built-in.a
Quoted 8 lines
Quoted 2 lines
Add a new dependency to avoid this.
Afaict this should be addressed by:
86fdf1fc60e9("net: ipa: remove a remoteproc dependency")which is present in linux-next.
Ok, good. I was testing with next-20210122, which was still lacking that commit.
Arnd
Quoted 20 lines · Arnd Bergmann
Quoted 18 lines · Bjorn Andersson
Quoted 14 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Compile-testing without
CONFIG_REMOTEPROCresults in a build failure:Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
ipa_main.c
net/ipa/ipa_main.o:(ipa_probe) in archivedrivers/built-in.ald.lld: error: undefined symbol:
rproc_putQuoted 4 lines
Quoted 4 lines
Quoted 4 lines
referenced by
ipa_main.c
net/ipa/ipa_main.o:(ipa_probe) in archivedrivers/built-in.a
referenced byipa_main.c
net/ipa/ipa_main.o:(ipa_remove) in archivedrivers/built-in.aAdd a new dependency to avoid this.
Quoted 8 lines
Quoted 5 lines
Afaict this should be addressed by:
86fdf1fc60e9("net: ipa: remove a remoteproc dependency")which is present in linux-next.
Ok, good. I was testing with next-20210122, which was still lacking that commit.
Yes, for various reasons this took a while to get incorporated. It just got accepted over the weekend. Thanks for mentioning it.
-Alex
Quoted 3 lines
Arnd