Skip to contentSkip to conversation

KVM: Documentation: Fix spec for KVM_CAP_ENABLE_CAP_VM

PATCH Applied Quentin Perret 4 participants 5 messages Jan 8, 2021 – Jan 18, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: Documentation: Fix spec for KVM_CAP_ENABLE_CAP_VM

The documentation classifies KVM_ENABLE_CAP with KVM_CAP_ENABLE_CAP_VM as a vcpu ioctl, which is incorrect. Fix it by specifying it as a VM ioctl.

Fixes e5d83c74a580 ("kvm: make KVM_CAP_ENABLE_CAP_VM architecture agnostic")
---
 Documentation/virt/kvm/api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/virt/kvm/api.rst +1 -1
index 70254eaa5229..68898b623d86 100644
@@ -1328,7 +1328,7 @@ documentation when it pops into existence).
 
 :Capability: KVM_CAP_ENABLE_CAP_VM
 :Architectures: all
-:Type: vcpu ioctl
+:Type: vm ioctl
 :Parameters: struct kvm_enable_cap (in)
 :Returns: 0 on success; -1 on error
 
Signature · 1 line
2.30.0.284.gd98b1dd5eaa7-goog
#1 lore raw
Quoted 3 lines · Quentin Perret

The documentation classifies KVM_ENABLE_CAP with KVM_CAP_ENABLE_CAP_VM as a vcpu ioctl, which is incorrect. Fix it by specifying it as a VM ioctl.

Anything I should do on this one?

Thanks,
Quentin

Acked-by on v1 1/1
#2 lore raw
In reply to Quentin Perret
Quoted 15 lines · Quentin Perret

The documentation classifies KVM_ENABLE_CAP with KVM_CAP_ENABLE_CAP_VM as a vcpu ioctl, which is incorrect. Fix it by specifying it as a VM ioctl.

Fixes e5d83c74a580 ("kvm: make KVM_CAP_ENABLE_CAP_VM architecture agnostic")
---
 Documentation/virt/kvm/api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/virt/kvm/api.rst +0 -0
index 70254eaa5229..68898b623d86 100644

Documentation/virt/kvm/api.rst documentation when it pops into existence). · line 1333

Quoted 7 lines
Documentation/virt/kvm/api.rst +1 -1
@@ -1328,7 +1328,7 @@ documentation when it pops into existence).
 
 :Capability: KVM_CAP_ENABLE_CAP_VM
 :Architectures: all
-:Type: vcpu ioctl
+:Type: vm ioctl
 :Parameters: struct kvm_enable_cap (in)
 :Returns: 0 on success; -1 on error

I tripped over this as well, so:

Will

reviewer Reviewed-by
#3 lore raw
Quoted 4 lines · Will Deacon
Quoted 3 lines · Quentin Perret

The documentation classifies KVM_ENABLE_CAP with KVM_CAP_ENABLE_CAP_VM as a vcpu ioctl, which is incorrect. Fix it by specifying it as a VM ioctl.

On a related topic, x86 should report KVM_CAP_ENABLE_CAP as supported, it's had a vCPU version since commit 5c919412fe61 ("kvm/x86: Hyper-V synthetic interrupt controller"). I'll send a patch.

Quoted 21 lines
Quoted 11 lines
Fixes e5d83c74a580 ("kvm: make KVM_CAP_ENABLE_CAP_VM architecture agnostic")
---
 Documentation/virt/kvm/api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/virt/kvm/api.rst +0 -0
index 70254eaa5229..68898b623d86 100644

Documentation/virt/kvm/api.rst documentation when it pops into existence). · line 1333

Quoted 7 lines
Documentation/virt/kvm/api.rst +1 -1
@@ -1328,7 +1328,7 @@ documentation when it pops into existence).
 
 :Capability: KVM_CAP_ENABLE_CAP_VM
 :Architectures: all
-:Type: vcpu ioctl
+:Type: vm ioctl
 :Parameters: struct kvm_enable_cap (in)
 :Returns: 0 on success; -1 on error

I tripped over this as well, so:

Quoted 1 line

The problem is that you read the documentation. Who does that?

maintainer Applied
#4 lore raw
In reply to Will Deacon
Quoted 26 lines · Will Deacon
Quoted 15 lines · Quentin Perret

The documentation classifies KVM_ENABLE_CAP with KVM_CAP_ENABLE_CAP_VM as a vcpu ioctl, which is incorrect. Fix it by specifying it as a VM ioctl.

Fixes e5d83c74a580 ("kvm: make KVM_CAP_ENABLE_CAP_VM architecture agnostic")
---
  Documentation/virt/kvm/api.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/virt/kvm/api.rst +0 -0
index 70254eaa5229..68898b623d86 100644

Documentation/virt/kvm/api.rst documentation when it pops into existence). · line 1333

Quoted 7 lines
Documentation/virt/kvm/api.rst +1 -1
@@ -1328,7 +1328,7 @@ documentation when it pops into existence).
 
  :Capability: KVM_CAP_ENABLE_CAP_VM
  :Architectures: all
-:Type: vcpu ioctl
+:Type: vm ioctl
  :Parameters: struct kvm_enable_cap (in)
  :Returns: 0 on success; -1 on error

I tripped over this as well, so:

Quoted 4 lines

Will

Queued, thanks.

Paolo