cmd: CMD_ACPI depends on ACPIGEN
PATCH 1/1 cmd: CMD_ACPI depends on ACPIGEN
Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and CONFIG_ACPIGEN=n fails with
ld.bfd: cmd/built-in.o: in function `do_acpi_items':cmd/acpi.c:162: undefined reference to `acpi_dump_items'
Add the missing configuration dependency.
--- cmd/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
cmd/Kconfig +2 -1
@@ -84,7 +84,8 @@ menu "Info commands" config CMD_ACPI bool "acpi" - default y if ACPIGEN + depends on ACPIGEN + default y help List and dump ACPI tables. ACPI (Advanced Configuration and Power Interface) is used mostly on x86 for providing information to the
--
2.29.2
PATCH 1/1 cmd: CMD_ACPI depends on ACPIGEN
Quoted 18 lines · Heinrich Schuchardt
Trying to compile qemu-x86_64_defconfig with
CONFIG_CMD_ACPI=yandCONFIG_ACPIGEN=nfails withld.bfd:
cmd/built-in.o: in function `do_acpi_items':cmd/acpi.c:162: undefined reference to `acpi_dump_items'Add the missing configuration dependency.
Signed-off-by Heinrich Schuchardt <[email protected]>--- cmd/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)cmd/Kconfig +0
-0
cmd/Kconfig menu "Info commands" · line 88
Quoted 6 lines
cmd/Kconfig +2
-1@@ -84,7 +84,8 @@ menu "Info commands" config CMD_ACPI bool "acpi" - default y if ACPIGEN + depends on ACPIGEN + default y
Shouldn't be rather
default ACPIGEN
?
Quoted 6 lines
cmd/Kconfig +0
-1help List and dump ACPI tables. ACPI (Advanced Configuration and Power Interface) is used mostly on x86 for providing information to the --2.29.2
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH 1/1 cmd: CMD_ACPI depends on ACPIGEN
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Heinrich Schuchardt
Trying to compile qemu-x86_64_defconfig with
CONFIG_CMD_ACPI=yandCONFIG_ACPIGEN=nfails withld.bfd:
cmd/built-in.o: in function `do_acpi_items':cmd/acpi.c:162: undefined reference to `acpi_dump_items'Add the missing configuration dependency.
...
Quoted 11 lines
cmd/Kconfig menu "Info commands" · line 88
Quoted 5 lines
config
CMD_ACPIcmd/Kconfig +2
-1bool "acpi" - default y if ACPIGEN + depends on ACPIGEN + default yShouldn't be rather
default ACPIGEN
?
Actually it makes no difference...
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH 1/1 cmd: CMD_ACPI depends on ACPIGEN
Am 20. Januar 2021 21:47:45 MEZ schrieb Andy Shevchenko <[email protected]>:
Quoted 20 lines · Andy Shevchenko
Quoted 8 lines · Heinrich Schuchardt
Quoted 7 lines
Trying to compile qemu-x86_64_defconfig with
CONFIG_CMD_ACPI=yandCONFIG_ACPIGEN=nfails withld.bfd:
cmd/built-in.o: in function `do_acpi_items':cmd/acpi.c:162: undefined reference to `acpi_dump_items'Add the missing configuration dependency.
...
Quoted 8 lines
cmd/Kconfig menu "Info commands" · line 88
Quoted 5 lines
config
CMD_ACPIcmd/Kconfig +2
-1bool "acpi" - default y if ACPIGEN + depends on ACPIGEN + default yShouldn't be rather
Quoted 3 lines
Quoted 3 lines
default ACPIGEN
?
Thanks for reviewing.
You cannot drop the depends line.
If you only want to change the last line only, 'default y' is easier to read and matches the style of the rest of our code.
Best regards
Heinrich
Quoted 2 lines
Actually it makes no difference...
PATCH 1/1 cmd: CMD_ACPI depends on ACPIGEN
In reply to Heinrich SchuchardtQuoted 7 lines · Heinrich Schuchardt
Trying to compile qemu-x86_64_defconfig with
CONFIG_CMD_ACPI=yandCONFIG_ACPIGEN=nfails withld.bfd:
cmd/built-in.o: in function `do_acpi_items':cmd/acpi.c:162: undefined reference to `acpi_dump_items'
Quoted 7 lines
Add the missing configuration dependency.
Signed-off-by Heinrich Schuchardt <[email protected]>--- cmd/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
PATCH 1/1 cmd: CMD_ACPI depends on ACPIGEN
Quoted 11 lines · Bin Meng
Quoted 9 lines · Heinrich Schuchardt
Trying to compile qemu-x86_64_defconfig with
CONFIG_CMD_ACPI=yandCONFIG_ACPIGEN=nfails withld.bfd:
cmd/built-in.o: in function `do_acpi_items':cmd/acpi.c:162: undefined reference to `acpi_dump_items'Add the missing configuration dependency.
Quoted 7 lines
Quoted 5 lines
Signed-off-by Heinrich Schuchardt <[email protected]>--- cmd/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Reviewed-by Bin Meng <[email protected]>
applied to u-boot-x86, thanks!