Skip to contentSkip to conversation

configure.ac: More descriptive NUMA error message

PATCH New Petr Vorel 2 participants 3 messages Jan 21, 2021

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH v2 1/1 configure.ac: More descriptive NUMA error message

Some people were confused and searched for libnuma.so.2, which does not exist.

Required is libnuma.so.1, but with LIBNUMA_API_VERSION >= 2. The API version is tighten to libnuma version in git, but that has nothing to do with library soname version, which is still 1.0.0.

---
* Changes v1->v2:
Used Cyril's version, which is more readable.

Kind regards,
Petr

 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure.ac +1 -1
index e44e25cc6..aa8532119 100644
@@ -347,7 +347,7 @@ LTP_CHECK_SYSCALL_FCNTL
 
 if test "x$with_numa" = xyes; then
 	LTP_CHECK_SYSCALL_NUMA
-	numa_error_msg="test requires libnuma >= 2 and it's development packages"
+	numa_error_msg="test requires libnuma development packages with LIBNUMA_API_VERSION >= 2"
 else
 	numa_error_msg="NUMA support was disabled during build"
 fi
Signature · 1 line
2.30.0
#1 lore raw

PATCH v2 1/1 configure.ac: More descriptive NUMA error message

Hi!

Quoted 9 lines

Some people were confused and searched for libnuma.so.2, which does not exist.

Required is libnuma.so.1, but with LIBNUMA_API_VERSION >= 2. The API version is tighten to libnuma version in git, but that has nothing to do with library soname version, which is still 1.0.0.

I consider this safe for the release, please push.

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#2 lore raw

PATCH v2 1/1 configure.ac: More descriptive NUMA error message

Quoted 4 lines

Hi!

Quoted 2 lines

Some people were confused and searched for libnuma.so.2, which does not exist.

Quoted 8 lines
Quoted 6 lines

Required is libnuma.so.1, but with LIBNUMA_API_VERSION >= 2. The API version is tighten to libnuma version in git, but that has nothing to do with library soname version, which is still 1.0.0.

I consider this safe for the release, please push.

Thanks, merged!

Kind regards,
Petr