Skip to contentSkip to conversation

ARM: tegra: ouya: Fix eMMC on specific bootloaders

PATCH In review Peter Geis 2 participants 2 messages Jan 7, 2021 – Jan 21, 2021

Subsystems (2)
Device tree bindings Tegra architecture support
lore
Share & tools
lore

Peter Geis

author
#0 lore raw

PATCH v3 1/1 ARM: tegra: ouya: Fix eMMC on specific bootloaders

Ouya fails to detect the eMMC module when booted via certain bootloaders. Fastboot and hard-kexec bootloaders fail while u-boot does not. It was discovered that the issue manifests if the sdmmc4 alternate configuration clock pin is input disabled.

Ouya uses sdmmc4 in the primary pin configuration. It is unknown why this occurs, though it is likely related to other eMMC limitations experienced on Ouya.

For now, fix it by enabling input on cam_mclk_pcc0.

Fixes d7195ac5c9c5 ("ARM: tegra: Add device-tree for Ouya")
Reported-by Matt Merhar <[email protected]>
Tested-by Matt Merhar <[email protected]>
Signed-off-by Peter Geis <[email protected]>

---
Changes v3:
Removed stable tag, applies to v5.11+ only

Changes v2:
-Added stable tag.
-Improved commit message.

 arch/arm/boot/dts/tegra30-ouya.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/tegra30-ouya.dts +2 -2
index 74da1360d297..0368b3b816ef 100644
@@ -4352,8 +4352,8 @@ cam_mclk_pcc0 {
 		nvidia,pins = "cam_mclk_pcc0";
 		nvidia,function = "vi_alt3";
 		nvidia,pull = <TEGRA_PIN_PULL_NONE>;
-		nvidia,tristate = <TEGRA_PIN_ENABLE>;
-		nvidia,enable-input = <TEGRA_PIN_DISABLE>;
+		nvidia,tristate = <TEGRA_PIN_DISABLE>;
+		nvidia,enable-input = <TEGRA_PIN_ENABLE>;
 	};
 	pcc1 {
 		nvidia,pins = "pcc1";
Signature · 1 line
2.25.1
Acked-by on v3 1/1
#1 lore raw
Quoted 20 lines · Peter Geis

Ouya fails to detect the eMMC module when booted via certain bootloaders. Fastboot and hard-kexec bootloaders fail while u-boot does not. It was discovered that the issue manifests if the sdmmc4 alternate configuration clock pin is input disabled.

Ouya uses sdmmc4 in the primary pin configuration. It is unknown why this occurs, though it is likely related to other eMMC limitations experienced on Ouya.

For now, fix it by enabling input on cam_mclk_pcc0.

Fixes d7195ac5c9c5 ("ARM: tegra: Add device-tree for Ouya")
Reported-by Matt Merhar <[email protected]>
Tested-by Matt Merhar <[email protected]>
Signed-off-by Peter Geis <[email protected]>

---
Changes v3:
Removed stable tag, applies to v5.11+ only

Changes v2:

Review

Quoted 5 lines
(quoted diff) +0 -2
-Added stable tag.
-Improved commit message.
 
 arch/arm/boot/dts/tegra30-ouya.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by Thierry Reding <[email protected]>

Arnd, Olof,

can you guys pick this up directly for v5.11, since I don't currently have any other fixes queued up?

Here's a patchwork link:

	http://patchwork.ozlabs.org/project/linux-tegra/patch/[email protected]/

Thanks,
Thierry

Quoted 18 lines
arch/arm/boot/dts/tegra30-ouya.dts +2 -2
index 74da1360d297..0368b3b816ef 100644
@@ -4352,8 +4352,8 @@ cam_mclk_pcc0 {
 		nvidia,pins = "cam_mclk_pcc0";
 		nvidia,function = "vi_alt3";
 		nvidia,pull = <TEGRA_PIN_PULL_NONE>;
-		nvidia,tristate = <TEGRA_PIN_ENABLE>;
-		nvidia,enable-input = <TEGRA_PIN_DISABLE>;
+		nvidia,tristate = <TEGRA_PIN_DISABLE>;
+		nvidia,enable-input = <TEGRA_PIN_ENABLE>;
 	};
 	pcc1 {
 		nvidia,pins = "pcc1";
Signature · 1 line
2.25.1