Skip to contentSkip to conversation

drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c

PATCH In review Bhaskar Chowdhury 3 participants 7 messages Feb 5, 2021 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c

s/fucking/invite/

---
 drivers/mtd/mtd_blkdevs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/mtd_blkdevs.c +1 -1
index fb8e12d590a1..756a0995e474 100644
@@ -523,7 +523,7 @@ int register_mtd_blktrans(struct mtd_blktrans_ops *tr)
 	int ret;
 
 	/* Register the notifier if/when the first device type is
-	   registered, to prevent the link/init ordering from fucking
+	   registered, to prevent the link/init ordering from invite
 	   us over. */
 	if (!blktrans_notifier.list.next)
 		register_mtd_user(&blktrans_notifier);

--
2.30.0

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

maintainer
#1 lore raw

Hi Bhaskar,

Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021 18:11:51 +0530:

Quoted 13 lines

s/fucking/invite/

---
 drivers/mtd/mtd_blkdevs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/mtd_blkdevs.c +0 -0
index fb8e12d590a1..756a0995e474 100644

drivers/mtd/mtd_blkdevs.c int register_mtd_blktrans(struct mtd_blktrans_ops *tr) · line 527

Quoted 6 lines
drivers/mtd/mtd_blkdevs.c +1 -1
@@ -523,7 +523,7 @@ int register_mtd_blktrans(struct mtd_blktrans_ops *tr)
 	int ret;
 
 	/* Register the notifier if/when the first device type is
-	   registered, to prevent the link/init ordering from fucking
+	   registered, to prevent the link/init ordering from invite
 	   us over. */

invite us over?

I'm not a native English speaker but this does not bring any value to my ears. Worse, I don't even get the point. Better rewrite the comment entirely than just swapping "fucking" with a random word, no?

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#2 lore raw
Quoted 27 lines · Miquel Raynal

Hi Bhaskar,

Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021 18:11:51 +0530:

Quoted 13 lines

s/fucking/invite/

---
 drivers/mtd/mtd_blkdevs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/mtd_blkdevs.c +0 -0
index fb8e12d590a1..756a0995e474 100644

drivers/mtd/mtd_blkdevs.c int register_mtd_blktrans(struct mtd_blktrans_ops *tr) · line 527

Quoted 6 lines
drivers/mtd/mtd_blkdevs.c +1 -1
@@ -523,7 +523,7 @@ int register_mtd_blktrans(struct mtd_blktrans_ops *tr)
 	int ret;
 
 	/* Register the notifier if/when the first device type is
-	   registered, to prevent the link/init ordering from fucking
+	   registered, to prevent the link/init ordering from invite
 	   us over. */

invite us over?

Quoted 4 lines

I'm not a native English speaker but this does not bring any value to my ears. Worse, I don't even get the point. Better rewrite the comment entirely than just swapping "fucking" with a random word, no?

Got your point , and I do understand "fuck" and "fucking" is so strong word that it is really difficult to replace with something else.

But..but you suggestion to rewrite the comments sounds good Miquel ...wish I could have that much time in hand to replace every sentence having that word ...all the patched sent with that word replaces...please step forward and make and send patches .

Today I sent 10 patches replacing that word(weather that make sense or not) you can see those in the ML ...please pick up as you wish and send patches.

I was simply replacing the word ..never bother about the meaning it conveys..doesn't matter really.

so...

Thanks.

Quoted 2 lines

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#3 lore raw

----- Ursprüngliche Mail -----

Quoted 7 lines

Von: "Bhaskar Chowdhury" <[email protected]>
An: "Miquel Raynal" <[email protected]>
CC: "richard" <[email protected]>, "Vignesh Raghavendra" <[email protected]>, "linux-mtd" <[email protected]>, "linux-kernel" <[email protected]>, "Randy Dunlap" <[email protected]>
Gesendet: Freitag, 5. Februar 2021 14:36:39
Betreff: Re: [PATCH] drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c

Quoted 7 lines
Quoted 6 lines · Miquel Raynal

Hi Bhaskar,

Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021 18:11:51 +0530:

Quoted 1 line

s/fucking/invite/

If you are afraid of "fucking", please replace it with "f*cking" or such. "invite" makes no sense.

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#4 lore raw
Quoted 11 lines · Richard Weinberger

----- Ursprüngliche Mail -----

Quoted 10 lines

Von: "Bhaskar Chowdhury" <[email protected]>
An: "Miquel Raynal" <[email protected]>
CC: "richard" <[email protected]>, "Vignesh Raghavendra" <[email protected]>, "linux-mtd" <[email protected]>, "linux-kernel" <[email protected]>, "Randy Dunlap" <[email protected]>
Gesendet: Freitag, 5. Februar 2021 14:36:39
Betreff: Re: [PATCH] drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c

Quoted 2 lines · Miquel Raynal

Hi Bhaskar,

Quoted 8 lines
Quoted 4 lines
Quoted 4 lines

Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021 18:11:51 +0530:

Quoted 1 line

s/fucking/invite/

If you are afraid of "fucking", please replace it with "f*cking" or such. "invite" makes no sense.

I am NOT afraid of anything ,just replacing the bad words ..that's all ...never bother to evaluate already bad sentences with correct word.

I know it is not make any sense ...still a better word ...

Quoted 2 lines

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

maintainer
#5 lore raw
In reply to Bhaskar Chowdhury

Hi Bhaskar,

Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021 19:06:39 +0530:

Quoted 36 lines · Miquel Raynal
Quoted 13 lines

Hi Bhaskar,

Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021 18:11:51 +0530:

Quoted 8 lines

s/fucking/invite/

---
 drivers/mtd/mtd_blkdevs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines

drivers/mtd/mtd_blkdevs.c int register_mtd_blktrans(struct mtd_blktrans_ops *t

Quoted 5 lines
drivers/mtd/mtd_blkdevs.c +0 -0
index fb8e12d590a1..756a0995e474 100644
@@ -523,7 +523,7 @@ int register_mtd_blktrans(struct mtd_blktrans_ops *t  

r)

Quoted 9 lines

drivers/mtd/mtd_blkdevs.c int register_mtd_blktrans(struct mtd_blktrans_ops *tr) · line 527

Quoted 6 lines
drivers/mtd/mtd_blkdevs.c +1 -1
 	int ret;
 
 	/* Register the notifier if/when the first device type is
-	   registered, to prevent the link/init ordering from fucking
+	   registered, to prevent the link/init ordering from invite
 	   us over. */  

invite us over?

Quoted 4 lines

I'm not a native English speaker but this does not bring any value to my ears. Worse, I don't even get the point. Better rewrite the comment entirely than just swapping "fucking" with a random word, no?

Got your point , and I do understand "fuck" and "fucking" is so strong word that it is really difficult to replace with something else.

Quoted 8 lines

But..but you suggestion to rewrite the comments sounds good Miquel ...wish I could have that much time in hand to replace every sentence having that word ...all the patched sent with that word replaces...please step forward and
make
and send patches .

Today I sent 10 patches replacing that word(weather that make sense or not) you can see those in the ML ...please pick up as you wish and send patches.

There are currently 21 uses of "fuck[ing]". It's not a mountain to climb. Nor a race.

Quoted 2 lines

I was simply replacing the word ..never bother about the meaning it conveys..doesn't matter really.

Are you kidding? What is the purpose of a comment if no one understands it after a blind change?

Quoted 3 lines

so...

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#6 lore raw
Quoted 47 lines · Miquel Raynal

Hi Bhaskar,

Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021 19:06:39 +0530:

Quoted 42 lines · Miquel Raynal
Quoted 13 lines

Hi Bhaskar,

Bhaskar Chowdhury <[email protected]> wrote on Fri, 5 Feb 2021 18:11:51 +0530:

Quoted 8 lines

s/fucking/invite/

---
 drivers/mtd/mtd_blkdevs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines

drivers/mtd/mtd_blkdevs.c int register_mtd_blktrans(struct mtd_blktrans_ops *t

Quoted 5 lines
drivers/mtd/mtd_blkdevs.c +0 -0
index fb8e12d590a1..756a0995e474 100644
@@ -523,7 +523,7 @@ int register_mtd_blktrans(struct mtd_blktrans_ops *t

r)

Quoted 9 lines

drivers/mtd/mtd_blkdevs.c int register_mtd_blktrans(struct mtd_blktrans_ops *tr) · line 527

Quoted 6 lines
drivers/mtd/mtd_blkdevs.c +1 -1
 	int ret;
 
 	/* Register the notifier if/when the first device type is
-	   registered, to prevent the link/init ordering from fucking
+	   registered, to prevent the link/init ordering from invite
 	   us over. */

invite us over?

Quoted 4 lines

I'm not a native English speaker but this does not bring any value to my ears. Worse, I don't even get the point. Better rewrite the comment entirely than just swapping "fucking" with a random word, no?

Got your point , and I do understand "fuck" and "fucking" is so strong word that it is really difficult to replace with something else.

But..but you suggestion to rewrite the comments sounds good Miquel ...wish I could have that much time in hand to replace every sentence having that word ...all the patched sent with that word replaces...please step forward and
make
and send patches .

Quoted 6 lines
Quoted 2 lines

Today I sent 10 patches replacing that word(weather that make sense or not) you can see those in the ML ...please pick up as you wish and send patches.

There are currently 21 uses of "fuck[ing]". It's not a mountain to climb. Nor a race.

✔ ~/git-linux/linux [master|✔]
19:28 $ search fuck | wc -l
15

Quoted 6 lines
Quoted 2 lines

I was simply replacing the word ..never bother about the meaning it conveys..doesn't matter really.

Are you kidding? What is the purpose of a comment if no one understands it after a blind change?

No I am not . But the sentences contains that word hardly have more meaning. But as you already said rewriting those comment would be a good idea...can you take up some of those??

Quoted 3 lines
Quoted 3 lines

so...

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/