syscalls/ipc: semctl07: Convert to new API and cleanup
PATCH v2 1/1 syscalls/ipc: semctl07: Convert to new API and cleanup
Signed-off-by Feiyu Zhu <[email protected]>
--- testcases/kernel/syscalls/ipc/semctl/Makefile | 4 +- testcases/kernel/syscalls/ipc/semctl/semctl07.c | 248 +++++++++++------------- 2 files changed, 114 insertions(+), 138 deletions(-)
testcases/kernel/syscalls/ipc/semctl/Makefile +2 -2
@@ -7,7 +7,7 @@ LTPLIBS = ltpipc ltpnewipc include $(top_srcdir)/include/mk/testcases.mk -semctl01 semctl06 semctl07: LTPLDLIBS = -lltpipc -semctl02 semctl03 semctl04 semctl05 semctl08 semctl09: LTPLDLIBS = -lltpnewipc +semctl01 semctl06: LTPLDLIBS = -lltpipc +semctl02 semctl03 semctl04 semctl05 semctl07 semctl08 semctl09: LTPLDLIBS = -lltpnewipc include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/ipc/semctl/semctl07.c +112 -136
288 lines not on this page · raw message
Signature · 1 line
1.8.3.1
PATCH v2 1/1 syscalls/ipc: semctl07: Convert to new API and cleanup
Hi!
Pushed with two minor changes, thanks.
Review
Quoted 1 line
(quoted diff) +1
-0+ if ((status = semctl(semid, 0, GETVAL)) == -1)
Since these calls are supposed to return positive value I've changed this condition to foo() < 0 instead.
Review
Quoted 1 line
(quoted diff) +1
-0+ tst_res(TFAIL, "semctl(GETVAL) failed errno = %d", errno);
And changed these to use TERRNO instead.
Signature · 2 lines
Cyril Hrubis [email protected]