mt76: mt7915: add support for continuous tx in testmode
Hello Shayne Chen,
The patch 3f0caa3cbf94: "mt76: mt7915: add support for continuous tx in testmode" from Jan 5, 2021, leads to the following static checker warning:
drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:597 mt7915_tm_set_tx_cont() error: uninitialized symbol 'mode'.
drivers/net/wireless/mediatek/mt76/mt7915/testmode.c
583 break;
584 case MT76_TM_TX_MODE_HE_EXT_SU:
585 mode = MT_PHY_TYPE_HE_EXT_SU;
586 break;
587 case MT76_TM_TX_MODE_HE_TB:
588 mode = MT_PHY_TYPE_HE_TB;
589 break;
590 case MT76_TM_TX_MODE_HE_MU:
591 mode = MT_PHY_TYPE_HE_MU;
592 break;
593 default:
"mode" is uninitialized on the default path.
594 break;
595 }
596
597 rateval = mode << 6 | rate_idx;
^^^^^^^^^
598 tx_cont->rateval = cpu_to_le16(rateval);
599
600 out:
601 if (!en) {
602 int ret;
603 regards,
dan carpenter
Quoted 1 line
Hello Shayne Chen,
Hi Dan,
right. I will post a fix soon.
Regards,
Lorenzo
Quoted 38 lines
The patch
3f0caa3cbf94: "mt76: mt7915: add support for continuous tx in testmode" from Jan 5, 2021, leads to the following static checker warning:drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:597 mt7915_tm_set_tx_cont() error: uninitialized symbol 'mode'.
drivers/net/wireless/mediatek/mt76/mt7915/testmode.c583 break; 584 case MT76_TM_TX_MODE_HE_EXT_SU: 585 mode = MT_PHY_TYPE_HE_EXT_SU; 586 break; 587 case MT76_TM_TX_MODE_HE_TB: 588 mode = MT_PHY_TYPE_HE_TB; 589 break; 590 case MT76_TM_TX_MODE_HE_MU: 591 mode = MT_PHY_TYPE_HE_MU; 592 break; 593 default:"mode" is uninitialized on the default path.
594 break; 595 } 596 597 rateval = mode << 6 | rate_idx; ^^^^^^^^^ 598 tx_cont->rateval = cpu_to_le16(rateval); 599 600 out: 601 if (!en) { 602 int ret; 603regards,
dan carpenter