Replace raw_spin_lock_irqsave with raw_spin_lock
Hi, Mika!
There is an interesting discussion [1] going on about necessity of the _irqsave/_irqrestore variants of spin lock in the IRQ handler.
It appears that in our driver(s) we have also such variants of spin locks in use. Do you have any idea why is it so?
A bonus question, why do we use _NO_THREAD flag explicitly as per Thomas [2] this won't work well with RT kernels?
[1]: https://lore.kernel.org/linux-gpio/[email protected]/T/#u
[2]: https://lore.kernel.org/linux-i2c/[email protected]/
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Andy Shevchenko
Hi, Mika!
There is an interesting discussion [1] going on about necessity of the _irqsave/_irqrestore variants of spin lock in the IRQ handler.
It appears that in our driver(s) we have also such variants of spin locks in use. Do you have any idea why is it so?
Okay, this is me, who did it in a copy'n'paste manner in the commit e64fbfa51e8f ("pinctrl: intel: Protect IO in few call backs by lock").
Quoted 2 lines
A bonus question, why do we use
_NO_THREADflag explicitly as per Thomas [2] this won't work well with RT kernels?
Okay, this part is explained in the commit 1a7d1cb81eb2 ("pinctrl: intel:
Prevent force threading of the interrupt handler").
Quoted 2 lines
[1]: https://lore.kernel.org/linux-gpio/[email protected]/T/#u
[2]: https://lore.kernel.org/linux-i2c/[email protected]/
Signature · 2 lines
With Best Regards, Andy Shevchenko