tools/resolve_btfids: add /libbpf to .gitignore
Subsystems (3)
PATCH 1/1 tools/resolve_btfids: add /libbpf to .gitignore
There is what I see after compiling the kernel:
# bpf-next...bpf-next/master ?? tools/bpf/resolve_btfids/libbpf/
--- tools/bpf/resolve_btfids/.gitignore | 1 + 1 file changed, 1 insertion(+)
tools/bpf/resolve_btfids/.gitignore +1 -0
@@ -1,2 +1,3 @@ /fixdep /resolve_btfids +/libbpf/
Signature · 1 line
2.30.0.478.g8a0d178c01-goog
Quoted 2 lines · Stanislav Fomichev
There is what I see after compiling the kernel:
typo: This?
Quoted 6 lines
# bpf-next...bpf-next/master ?? tools/bpf/resolve_btfids/libbpf/Signed-off-by Stanislav Fomichev <[email protected]>---
Jiri,
Is this
in separate directories")
?
Do we need similar stuff for libsubcmd (what's that, btw?)
Quoted 14 lines
tools/bpf/resolve_btfids/.gitignore | 1 + 1 file changed, 1 insertion(+)tools/bpf/resolve_btfids/.gitignore +1
-1@@ -1,2 +1,3 @@ /fixdep /resolve_btfids +/libbpf/ --2.30.0.478.g8a0d178c01-goog
Quoted 6 lines · Andrii Nakryiko
Quoted 2 lines · Stanislav Fomichev
There is what I see after compiling the kernel:
typo: This?
Yes, sure.
Quoted 8 lines
Quoted 5 lines
# bpf-next...bpf-next/master ?? tools/bpf/resolve_btfids/libbpf/Signed-off-by Stanislav Fomichev <[email protected]>---
Jiri,
Quoted 8 lines
Is this
Fixes fc6b48f692f8 ("tools/resolve_btfids: Build libbpf and libsubcmdin separate directories")
?
Do we need similar stuff for libsubcmd (what's that, btw?)
It's probably not needed because it has only .o files in there (.o are ignored in the root .gitignore).
I assume libbpf/ has an issue because there is bpf_helper_defs.h in that libbpf/ directory.
Not sure why it was removed in fc6b48f692f8 rather than being prefixed with libbpf/ directory.
I'll leave it up to Jiri to comment.
Quoted 14 lines
Quoted 14 lines
tools/bpf/resolve_btfids/.gitignore | 1 + 1 file changed, 1 insertion(+)tools/bpf/resolve_btfids/.gitignore +1
-1@@ -1,2 +1,3 @@ /fixdep /resolve_btfids +/libbpf/ --2.30.0.478.g8a0d178c01-goog
Quoted 26 lines · Stanislav Fomichev
Quoted 6 lines · Andrii Nakryiko
Quoted 2 lines · Stanislav Fomichev
There is what I see after compiling the kernel:
typo: This?
Yes, sure.
Quoted 15 lines
Quoted 5 lines
# bpf-next...bpf-next/master ?? tools/bpf/resolve_btfids/libbpf/Signed-off-by Stanislav Fomichev <[email protected]>---
Jiri,
Is this
Fixes fc6b48f692f8 ("tools/resolve_btfids: Build libbpf and libsubcmdin separate directories")
?
Quoted 8 lines
Quoted 1 line
Do we need similar stuff for libsubcmd (what's that, btw?)
It's probably not needed because it has only .o files in there (.o are ignored in the root .gitignore).
I assume libbpf/ has an issue because there isbpf_helper_defs.hin that libbpf/ directory.
Not sure why it was removed infc6b48f692f8rather than being prefixed with libbpf/ directory.
I'll leave it up to Jiri to comment.
you're right, thanks for the fix
jirka
Quoted 17 lines
Quoted 16 lines
Quoted 16 lines
tools/bpf/resolve_btfids/.gitignore | 1 + 1 file changed, 1 insertion(+)tools/bpf/resolve_btfids/.gitignore +1
-1@@ -1,2 +1,3 @@ /fixdep /resolve_btfids +/libbpf/ --2.30.0.478.g8a0d178c01-goog
Quoted 13 lines · Andrii Nakryiko
Quoted 2 lines · Stanislav Fomichev
There is what I see after compiling the kernel:
typo: This?
Quoted 6 lines
# bpf-next...bpf-next/master ?? tools/bpf/resolve_btfids/libbpf/Signed-off-by Stanislav Fomichev <[email protected]>---
Quoted 6 lines
Jiri,
Is this
Fixes fc6b48f692f8 ("tools/resolve_btfids: Build libbpf and libsubcmdin separate directories")
yes
Quoted 4 lines
?
Do we need similar stuff for libsubcmd (what's that, btw?)
as Stanislav said it's only .o files in there, so there's no need
it provides the parse_options functionality
jirka
Quoted 16 lines
Quoted 15 lines
tools/bpf/resolve_btfids/.gitignore | 1 + 1 file changed, 1 insertion(+)tools/bpf/resolve_btfids/.gitignore +1
-1@@ -1,2 +1,3 @@ /fixdep /resolve_btfids +/libbpf/ --2.30.0.478.g8a0d178c01-goog
This patch was applied to bpf/bpf-next.git (refs/heads/master):
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
Quoted 8 lines · On Thu, 11 Feb 2021 17:00:53 -0800 you wrote:
There is what I see after compiling the kernel:
# bpf-next...bpf-next/master ?? tools/bpf/resolve_btfids/libbpf/Signed-off-by Stanislav Fomichev <[email protected]>[...]
Here is the summary with links:
- [bpf-next] tools/resolve_btfids: add /libbpf to .gitignore
https://git.kernel.org/bpf/bpf-next/c/90a82b1fa40d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html