Skip to contentSkip to conversation

Please apply commit 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") to back to v5.10.y

DISCUSSION Salvatore Bonaccorso 4 participants 7 messages Feb 21, 2021 – Feb 22, 2021 Stable branch

lore
Share & tools
lore
#0 lore raw

Hi

517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") was applied to mainline fixing (restoring) behaviour to pre 5.7. As the commit message describes in effect, WBS was broken for all USB-BT adapters that do not support alt 6.

Can you consider it to apply it to back to 5.10.y?

Regards,
Salvatore

#1 lore raw
Quoted 8 lines · Salvatore Bonaccorso

Hi

517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") was applied to mainline fixing (restoring) behaviour to pre 5.7. As the commit message describes in effect, WBS was broken for all USB-BT adapters that do not support alt 6.

Can you consider it to apply it to back to 5.10.y?

I do not see any such git commit id in Linus's tree, are you sure you picked the right one?

greg k-h

#2 lore raw
Quoted 8 lines · Greg Kroah-Hartman
Quoted 7 lines · Salvatore Bonaccorso

Hi

517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") was applied to mainline fixing (restoring) behaviour to pre 5.7. As the commit message describes in effect, WBS was broken for all USB-BT adapters that do not support alt 6.

Quoted 4 lines
Quoted 1 line

Can you consider it to apply it to back to 5.10.y?

I do not see any such git commit id in Linus's tree, are you sure you picked the right one?

Full hash is 517b693351a2d04f3af1fc0e506ac7e1346094de.

Looks like it should work as I intended on current 5.10.y, but I didn't test that kernel.

#3 lore raw
Quoted 12 lines · Trent Piepho
Quoted 10 lines · Greg Kroah-Hartman
Quoted 8 lines · Salvatore Bonaccorso

Hi

517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") was applied to mainline fixing (restoring) behaviour to pre 5.7. As the commit message describes in effect, WBS was broken for all USB-BT adapters that do not support alt 6.

Can you consider it to apply it to back to 5.10.y?

Quoted 7 lines
Quoted 2 lines

I do not see any such git commit id in Linus's tree, are you sure you picked the right one?

Full hash is 517b693351a2d04f3af1fc0e506ac7e1346094de.

Looks like it should work as I intended on current 5.10.y, but I didn't test that kernel.

Ah, this thing isn't even in 5.11, it just now showed up in Linus's tree.

Give it time to hit at least a released version (i.e. 5.12-rc1) before we pull it into a stable release. Unless the bluetooth maintainers say it is ok to do so earlier than that.

thanks,

greg k-h

#4 lore raw

Hi Greg,

Quoted 21 lines · Greg Kroah-Hartman
Quoted 12 lines · Trent Piepho
Quoted 10 lines · Greg Kroah-Hartman
Quoted 8 lines · Salvatore Bonaccorso

Hi

517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") was applied to mainline fixing (restoring) behaviour to pre 5.7. As the commit message describes in effect, WBS was broken for all USB-BT adapters that do not support alt 6.

Can you consider it to apply it to back to 5.10.y?

Quoted 7 lines
Quoted 2 lines

I do not see any such git commit id in Linus's tree, are you sure you picked the right one?

Full hash is 517b693351a2d04f3af1fc0e506ac7e1346094de.

Looks like it should work as I intended on current 5.10.y, but I didn't test that kernel.

Quoted 6 lines

Ah, this thing isn't even in 5.11, it just now showed up in Linus's tree.

Give it time to hit at least a released version (i.e. 5.12-rc1) before we pull it into a stable release. Unless the bluetooth maintainers say it is ok to do so earlier than that.

Sure. We got a request in Debian to include the commit for an upcoming 5.10.y based update and just want to make sure we do not diverge here from upstream. But it's obviously good to wait then unless bluetooth maintainers give the ack earlier.

Thanks for the quick responses.

Regards,
Salvatore

#5 lore raw
Quoted 27 lines · Salvatore Bonaccorso

Hi Greg,

Quoted 24 lines · Greg Kroah-Hartman
Quoted 12 lines · Trent Piepho
Quoted 10 lines · Greg Kroah-Hartman
Quoted 8 lines · Salvatore Bonaccorso

Hi

517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") was applied to mainline fixing (restoring) behaviour to pre 5.7. As the commit message describes in effect, WBS was broken for all USB-BT adapters that do not support alt 6.

Can you consider it to apply it to back to 5.10.y?

Quoted 7 lines
Quoted 2 lines

I do not see any such git commit id in Linus's tree, are you sure you picked the right one?

Full hash is 517b693351a2d04f3af1fc0e506ac7e1346094de.

Looks like it should work as I intended on current 5.10.y, but I didn't test that kernel.

Ah, this thing isn't even in 5.11, it just now showed up in Linus's tree.

Quoted 8 lines
Quoted 3 lines

Give it time to hit at least a released version (i.e. 5.12-rc1) before we pull it into a stable release. Unless the bluetooth maintainers say it is ok to do so earlier than that.

Sure. We got a request in Debian to include the commit for an upcoming 5.10.y based update and just want to make sure we do not diverge here from upstream. But it's obviously good to wait then unless bluetooth maintainers give the ack earlier.

This seems sane, I'll queue it up now, thanks.

greg k-h

#6 lore raw
In reply to Trent Piepho
Quoted 12 lines · Trent Piepho
Quoted 10 lines · Greg Kroah-Hartman
Quoted 8 lines · Salvatore Bonaccorso

Hi

517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") was applied to mainline fixing (restoring) behaviour to pre 5.7. As the commit message describes in effect, WBS was broken for all USB-BT adapters that do not support alt 6.

Can you consider it to apply it to back to 5.10.y?

Quoted 7 lines
Quoted 2 lines

I do not see any such git commit id in Linus's tree, are you sure you picked the right one?

Full hash is 517b693351a2d04f3af1fc0e506ac7e1346094de.

Looks like it should work as I intended on current 5.10.y, but I didn't test that kernel.

I've been using it for a while now on top of 5.10.y; It fixes issues for me with both Intel and Broadcom based usb adapters. Fwiw i previously[0] suggested adding fixes/tested-by tags but those didn't make it into the merged version.

Regards,
Sjoerd

0: https://lore.kernel.org/lkml/[email protected]/