Skip to contentSkip to conversation

zbd: simplify zoneskip= validness check

PATCH New Alexey Dobriyan 1 participant 1 message Feb 22, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 2/5 zbd: simplify zoneskip= validness check

Simply check the remainder:

(zoneskip % zone_size) > 0

It will do the right thing for all zoneskip= values, and zone size being positive is checked earlier.

---

 zbd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
zbd.c +1 -3
@@ -285,9 +285,7 @@ static bool zbd_verify_sizes(void)
 				return false;
 			}
 
-			if (td->o.zone_skip &&
-			    (td->o.zone_skip < td->o.zone_size ||
-			     td->o.zone_skip % td->o.zone_size)) {
+			if (td->o.zone_skip % td->o.zone_size) {
 				log_err("%s: zoneskip %llu is not a multiple of the device zone size %llu.\n",
 					f->file_name, (unsigned long long) td->o.zone_skip,
 					(unsigned long long) td->o.zone_size);