staging: rtl8712: unterminated string leads to read overflow

PATCH New Dan Carpenter 1 participant 1 message Feb 24, 2021

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2021-02-24 08:48 UTC #0 lore raw

PATCH 1/1 staging: rtl8712: unterminated string leads to read overflow

The memdup_user() function does not necessarily return a NUL terminated string so this can lead to a read overflow. Switch from memdup_user() to strndup_user() to fix this bug.

Fixes c6dc001f2add ("staging: r8712u: Merging Realtek's latest (v2.6.6). Various fixes.")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/rtl8712/rtl871x_ioctl_linux.c +1 -1

index 81de5a9e6b67..60dd798a6e51 100644
@@ -924,7 +924,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
 	struct iw_point *dwrq = (struct iw_point *)awrq;
 
 	len = dwrq->length;
-	ext = memdup_user(dwrq->pointer, len);
+	ext = strndup_user(dwrq->pointer, len);
 	if (IS_ERR(ext))
 		return PTR_ERR(ext);

Signature · 1 line

2.30.0