Skip to contentSkip to conversation

linux-next: Signed-off-by missing for commit in the gpio-brgl-fixes tree

DISCUSSION Stephen Rothwell 3 participants 5 messages Mar 8, 2021 – Mar 10, 2021 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

Commits

eb441337c714 ("gpio: pca953x: Set IRQ type when handle Intel Galileo Gen 2") 809390219fb9 ("gpiolib: acpi: Allow to find GpioInt() resource by name and index") 62d5247d239d ("gpiolib: acpi: Add ACPI_GPIO_QUIRK_ABSOLUTE_NUMBER quirk") 6e5d5791730b ("gpiolib: acpi: Add missing IRQF_ONESHOT")

are missing a Signed-off-by from their committers.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw

Hi all,

Quoted 9 lines · On Tue, 9 Mar 2021 07:26:20 +1100 Stephen Rothwell <[email protected]> wrote:

Commits

eb441337c714 ("gpio: pca953x: Set IRQ type when handle Intel Galileo Gen 2") 809390219fb9 ("gpiolib: acpi: Allow to find GpioInt() resource by name and index") 62d5247d239d ("gpiolib: acpi: Add ACPI_GPIO_QUIRK_ABSOLUTE_NUMBER quirk") 6e5d5791730b ("gpiolib: acpi: Add missing IRQF_ONESHOT")

are missing a Signed-off-by from their committers.

This also applies to the gpio-intel-fixes tree (since it is now headed by the same commit as the gpio-brgl-fixes tree).

Signature · 2 lines
Cheers,
Stephen Rothwell
#2 lore raw
Quoted 12 lines · Stephen Rothwell

Hi all,

Quoted 8 lines · On Tue, 9 Mar 2021 07:26:20 +1100 Stephen Rothwell <[email protected]> wrote:

Commits

eb441337c714 ("gpio: pca953x: Set IRQ type when handle Intel Galileo Gen 2") 809390219fb9 ("gpiolib: acpi: Allow to find GpioInt() resource by name and index") 62d5247d239d ("gpiolib: acpi: Add ACPI_GPIO_QUIRK_ABSOLUTE_NUMBER quirk") 6e5d5791730b ("gpiolib: acpi: Add missing IRQF_ONESHOT")

Quoted 4 lines
Quoted 1 line

are missing a Signed-off-by from their committers.

This also applies to the gpio-intel-fixes tree (since it is now headed by the same commit as the gpio-brgl-fixes tree).

I rebased my branch according to Linus, but I have decided to take directly Bart's tree.
So when original will be fixed I'll fix mine.

Thanks!

P.S. Bart, you may simply merge my tag even on top of v5.12-rc2. It will save you time and keep the original SHA IDs.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
Quoted 15 lines · Andy Shevchenko
Quoted 9 lines · Stephen Rothwell
Quoted 8 lines · On Tue, 9 Mar 2021 07:26:20 +1100 Stephen Rothwell <[email protected]> wrote:

Commits

eb441337c714 ("gpio: pca953x: Set IRQ type when handle Intel Galileo Gen 2") 809390219fb9 ("gpiolib: acpi: Allow to find GpioInt() resource by name and index") 62d5247d239d ("gpiolib: acpi: Add ACPI_GPIO_QUIRK_ABSOLUTE_NUMBER quirk") 6e5d5791730b ("gpiolib: acpi: Add missing IRQF_ONESHOT")

Quoted 4 lines
Quoted 1 line

are missing a Signed-off-by from their committers.

This also applies to the gpio-intel-fixes tree (since it is now headed by the same commit as the gpio-brgl-fixes tree).

Quoted 8 lines

I rebased my branch according to Linus, but I have decided to take directly Bart's tree.
So when original will be fixed I'll fix mine.

Thanks!

P.S. Bart, you may simply merge my tag even on top of v5.12-rc2. It will save you time and keep the original SHA IDs.

I think I have to elaborate.
1/ you need to drop those commits from your tree (yeah, rebase :-(, nut you may
do it interactively and inject the merge in the same location in the
history)
2/ instead of cherry-picking them run something like
git fetch [email protected]:pub/scm/linux/kernel/git/andy/linux-gpio-intel.git intel-gpio-v5.12-2 git merge FETCH_HEAD

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
Quoted 25 lines · Andy Shevchenko
Quoted 15 lines · Andy Shevchenko
Quoted 9 lines · Stephen Rothwell
Quoted 8 lines · On Tue, 9 Mar 2021 07:26:20 +1100 Stephen Rothwell <[email protected]> wrote:

Commits

eb441337c714 ("gpio: pca953x: Set IRQ type when handle Intel Galileo Gen 2") 809390219fb9 ("gpiolib: acpi: Allow to find GpioInt() resource by name and index") 62d5247d239d ("gpiolib: acpi: Add ACPI_GPIO_QUIRK_ABSOLUTE_NUMBER quirk") 6e5d5791730b ("gpiolib: acpi: Add missing IRQF_ONESHOT")

Quoted 4 lines
Quoted 1 line

are missing a Signed-off-by from their committers.

This also applies to the gpio-intel-fixes tree (since it is now headed by the same commit as the gpio-brgl-fixes tree).

Quoted 8 lines

I rebased my branch according to Linus, but I have decided to take directly Bart's tree.
So when original will be fixed I'll fix mine.

Thanks!

P.S. Bart, you may simply merge my tag even on top of v5.12-rc2. It will save you time and keep the original SHA IDs.

Quoted 7 lines

I think I have to elaborate.
1/ you need to drop those commits from your tree (yeah, rebase :-(, nut you may
do it interactively and inject the merge in the same location in the
history)
2/ instead of cherry-picking them run something like
git fetch [email protected]:pub/scm/linux/kernel/git/andy/linux-gpio-intel.git intel-gpio-v5.12-2 git merge FETCH_HEAD

Linus applied as is.
Problem solved :-)

Signature · 2 lines
With Best Regards,
Andy Shevchenko