mm: cma: Fix potential null dereference on pointer cma
Subsystems (3)
PATCH 1/1 mm: cma: Fix potential null dereference on pointer cma
From: Colin Ian King <[email protected]>
At the start of the function there is a null pointer check on cma and then branch to error handling label 'out'. The subsequent call to cma_sysfs_fail_pages_count dereferences cma, hence there is a potential null pointer deference issue. Fix this by only calling cma_sysfs_fail_pages_count if cma is not null.
Addresses-Coverity: ("Dereference after null check")
--- mm/cma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
mm/cma.c +2 -1
@@ -512,7 +512,8 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align,cma_sysfs_alloc_pages_count (cma, count); }else {count_vm_event (CMA_ALLOC_FAIL ); -cma_sysfs_fail_pages_count (cma, count); +if (cma) +cma_sysfs_fail_pages_count (cma, count); }return page;
Signature · 1 line
2.30.2
Quoted 11 lines · Colin King
From: Colin Ian King <[email protected]>
At the start of the function there is a null pointer check on cma and then branch to error handling label 'out'. The subsequent call to
cma_sysfs_fail_pages_countdereferences cma, hence there is a potential null pointer deference issue. Fix this by only callingcma_sysfs_fail_pages_countif cma is not null.Addresses-Coverity: ("Dereference after null check")
Fixes dc4764f7e9ac ("mm: cma: support sysfs")Signed-off-by Colin Ian King <[email protected]>
Quoted 6 lines · Colin King
From: Colin Ian King <[email protected]>
At the start of the function there is a null pointer check on cma and then branch to error handling label 'out'. The subsequent call to
cma_sysfs_fail_pages_countdereferences cma, hence there is a potential null pointer deference issue. Fix this by only calling
As far as I can tell, it's not possible to actually cause that null failure with the existing kernel code paths. *Might* be worth mentioning that here (unless I'm wrong), but either way, looks good, so:
thanks,
Signature · 2 lines
John Hubbard NVIDIA
Quoted 24 lines
cma_sysfs_fail_pages_countif cma is not null.Addresses-Coverity: ("Dereference after null check")
Fixes dc4764f7e9ac ("mm: cma: support sysfs")Signed-off-by Colin Ian King <[email protected]>--- mm/cma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)mm/cma.c +2
-1@@ -512,7 +512,8 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align,cma_sysfs_alloc_pages_count (cma, count); }else {count_vm_event (CMA_ALLOC_FAIL ); -cma_sysfs_fail_pages_count (cma, count); +if (cma) +cma_sysfs_fail_pages_count (cma, count); }return page;