cifsd: Fix a use after free on error path
Subsystems (3)
PATCH 1/1 cifsd: Fix a use after free on error path
The ksmbd_free_work_struct() frees "work" so we need to swap the order of these two function calls to avoid a use after free.
Fixes cabcebc31de4 ("cifsd: introduce SMB3 kernel server")
Signed-off-by Dan Carpenter <[email protected]>
--- fs/cifsd/oplock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/cifsd/oplock.c +1 -1
@@ -638,8 +638,8 @@ static void __smb2_oplock_break_noti(struct work_struct *wk)if (allocate_oplock_break_buf (work)) {ksmbd_err ("smb2_allocate_rsp_buf failed! " );atomic_dec (&conn->r_count); -ksmbd_free_work_struct (work);ksmbd_fd_put (work, fp); +ksmbd_free_work_struct (work);return ; }
Signature · 1 line
2.30.2
Quoted 5 lines · Dan Carpenter
The
ksmbd_free_work_struct()frees "work" so we need to swap the order of these two function calls to avoid a use after free.Fixes cabcebc31de4 ("cifsd: introduce SMB3 kernel server")Signed-off-by Dan Carpenter <[email protected]>
Thanks.
Reviewed-by Sergey Senozhatsky <[email protected]>
-ss