ovl: fix missing revert_creds() on error path
Subsystems (2)
PATCH 1/1 ovl: fix missing revert_creds() on error path
Smatch complains about missing that the ovl_override_creds() doesn't have a matching revert_creds() if the dentry is disconnected. Fix this by moving the ovl_override_creds() until after the disconnected check.
Fixes aa3ff3c152ff ("ovl: copy up of disconnected dentries")
Signed-off-by Dan Carpenter <[email protected]>
--- fs/overlayfs/copy_up.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/overlayfs/copy_up.c +2 -1
@@ -932,7 +932,7 @@ static int ovl_copy_up_one(struct dentry *parent, struct dentry *dentry,static int ovl_copy_up_flags (struct dentry *dentry,int flags) {int err =0 ; -const struct cred *old_cred =ovl_override_creds (dentry->d_sb); +const struct cred *old_cred;bool disconnected = (dentry->d_flags &DCACHE_DISCONNECTED );/*
@@ -943,6 +943,7 @@ static int ovl_copy_up_flags(struct dentry *dentry, int flags)if (WARN_ON (disconnected &&d_is_dir (dentry)))return -EIO ; + old_cred =ovl_override_creds (dentry->d_sb);while (!err) {struct dentry *next;struct dentry *parent =NULL ;
Signature · 1 line
2.30.2
Quoted 7 lines · Dan Carpenter
Smatch complains about missing that the
ovl_override_creds()doesn't have a matchingrevert_creds()if the dentry is disconnected. Fix this by moving theovl_override_creds()until after the disconnected check.Fixes aa3ff3c152ff ("ovl: copy up of disconnected dentries")Signed-off-by Dan Carpenter <[email protected]>
Thanks, applied.
Miklos