Skip to contentSkip to conversation

RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server

PATCH Applied Potnuri Bharat Teja 3 participants 3 messages Mar 24, 2021 – Mar 25, 2021

Subsystems (2)
lore
Share & tools
lore

Potnuri Bharat Teja

author maintainer
#0 lore raw

PATCH v2 1/1 RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server

Not setting ipv6 bit while destroying ipv6 listening servers may result in potential fatal adapter errors due to lookup engine memory hash errors. Therefore always set ipv6 field while destroying ipv6 listening servers.

Fixes 830662f6f032 ("RDMA/cxgb4: Add support for active and passive open connection with IPv6 address")

---
Changes since v0:
- modified commit description to inform the severity of patch. Changes since v1:
- removed extra variable as per Leon.
---

---
 drivers/infiniband/hw/cxgb4/cm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/infiniband/hw/cxgb4/cm.c +2 -2
index 8769e7aa097f..81903749d241 100644
@@ -3610,13 +3610,13 @@ int c4iw_destroy_listen(struct iw_cm_id *cm_id)
 	    ep->com.local_addr.ss_family == AF_INET) {
 		err = cxgb4_remove_server_filter(
 			ep->com.dev->rdev.lldi.ports[0], ep->stid,
-			ep->com.dev->rdev.lldi.rxq_ids[0], 0);
+			ep->com.dev->rdev.lldi.rxq_ids[0], false);
 	} else {
 		struct sockaddr_in6 *sin6;
 		c4iw_init_wr_wait(ep->com.wr_waitp);
 		err = cxgb4_remove_server(
 				ep->com.dev->rdev.lldi.ports[0], ep->stid,
-				ep->com.dev->rdev.lldi.rxq_ids[0], 0);
+				ep->com.dev->rdev.lldi.rxq_ids[0], true);
 		if (err)
 			goto done;
 		err = c4iw_wait_for_reply(&ep->com.dev->rdev, ep->com.wr_waitp,
Signature · 1 line
2.24.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 12 lines · Potnuri Bharat Teja

Not setting ipv6 bit while destroying ipv6 listening servers may result in potential fatal adapter errors due to lookup engine memory hash errors. Therefore always set ipv6 field while destroying ipv6 listening servers.

Fixes 830662f6f032 ("RDMA/cxgb4: Add support for active and passive open connection with IPv6 address")

---
Changes since v0:
- modified commit description to inform the severity of patch. Changes since v1:
- removed extra variable as per Leon.
---

Quoted 4 lines
---
 drivers/infiniband/hw/cxgb4/cm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Thanks,

maintainer Applied
#2 lore raw
In reply to Potnuri Bharat Teja
Quoted 13 lines · Potnuri Bharat Teja

Not setting ipv6 bit while destroying ipv6 listening servers may result in potential fatal adapter errors due to lookup engine memory hash errors. Therefore always set ipv6 field while destroying ipv6 listening servers.

Fixes 830662f6f032 ("RDMA/cxgb4: Add support for active and passive open connection with IPv6 address")

---
Changes since v0:
- modified commit description to inform the severity of patch. Changes since v1:
- removed extra variable as per Leon.
---

Quoted 3 lines
---
 drivers/infiniband/hw/cxgb4/cm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to for-rc, thanks

Jason