staging: rtl8712: removed unnecessary blank line
PATCH 1/1 staging: rtl8712: removed unnecessary blank line
Cleanup patch for CHECK: blank lines aren't necessary after an open brace '{'
Reported by checkpatch
--- drivers/staging/rtl8712/usb_intf.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/rtl8712/usb_intf.c +3 -4
@@ -36,7 +36,6 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,static void r871xu_dev_remove (struct usb_interface *pusb_intf);static const struct usb_device_id rtl871x_usb_id_tbl[] = { -/* RTL8188SU */ /* Realtek */ {USB_DEVICE (0x0BDA ,0x8171 )},
@@ -441,7 +440,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,for (i =0 , offset =0 ; i <128 ; i +=8 , offset++)r8712_efuse_pg_packet_read (padapter, offset, - &pdata[i]); + &pdata[i]);if (!r8712_initmac || !mac_pton (r8712_initmac, mac)) {/* Use the mac address stored in the Efuse
@@ -561,10 +560,10 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,*/ mac[0 ] &=0xFE ;dev_info (&udev->dev, -"r8712u: MAC Address from user = %pM\n" , mac); +"r8712u: MAC Address from user = %pM\n" , mac); }else {dev_info (&udev->dev, -"r8712u: MAC Address from efuse = %pM\n" , mac); +"r8712u: MAC Address from efuse = %pM\n" , mac); }ether_addr_copy (pnetdev->dev_addr, mac); }
Signature · 1 line
2.30.2
Greg KH
maintainerQuoted 3 lines · Mitali Borkar
Cleanup patch for CHECK: blank lines aren't necessary after an open brace '{'
Reported by checkpatch
But you did more than just the above in this patch, which is not ok :(
Okay, should I rename the patch? I removed a line and matched alignment, so should I rename this appropriately?
Quoted 7 lines · On Thu, 8 Apr, 2021, 13:30 Greg KH, <[email protected]> wrote:
Quoted 3 lines · Mitali Borkar
Cleanup patch for CHECK: blank lines aren't necessary after an open brace '{'
Reported by checkpatchBut you did more than just the above in this patch, which is not ok :(
Greg KH
maintainerA: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
Quoted 1 line · Mitali Borkar
Okay, should I rename the patch?
I can't take it as-is, so you need to change something :)
Quoted 2 lines
I removed a line and matched alignment, so should I rename this appropriately?
Only do one logical thing per patch, so if this is 2 logical things, then you need 2 patches, right?
thanks,
greg k-h