drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()
Subsystems (5)
PATCH 1/1 drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()
The dp->train_set[] for this driver is only two characters, not four so this memsets too much. Fortunately, this ends up corrupting a struct hole and not anything important.
--- drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/xlnx/zynqmp_dp.c +1 -1
@@ -866,7 +866,7 @@ static int zynqmp_dp_train(struct zynqmp_dp *dp)return ret;zynqmp_dp_write (dp,ZYNQMP_DP_SCRAMBLING_DISABLE ,1 ); -memset (dp->train_set,0 ,4 ); +memset (dp->train_set,0 ,sizeof (dp->train_set)); ret =zynqmp_dp_link_train_cr (dp);if (ret)return ret;
Signature · 6 lines
2.30.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 16 lines · Dan Carpenter
The dp->train_set[] for this driver is only two characters, not four so this memsets too much. Fortunately, this ends up corrupting a struct hole and not anything important.
Fixes d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")Signed-off-by Dan Carpenter <[email protected]>--- drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/xlnx/zynqmp_dp.c +0
-0
drivers/gpu/drm/xlnx/zynqmp_dp.c static int zynqmp_dp_train(struct zynqmp_dp *dp) · line 872
Quoted 8 lines
drivers/gpu/drm/xlnx/zynqmp_dp.c +1
-1@@ -866,7 +866,7 @@ static int zynqmp_dp_train(struct zynqmp_dp *dp)return ret;zynqmp_dp_write (dp,ZYNQMP_DP_SCRAMBLING_DISABLE ,1 ); -memset (dp->train_set,0 ,4 ); +memset (dp->train_set,0 ,sizeof (dp->train_set)); ret =zynqmp_dp_link_train_cr (dp);if (ret)return ret;
Thanks,
Michal
Quoted 20 lines · Michal Simek
Quoted 17 lines · Dan Carpenter
The dp->train_set[] for this driver is only two characters, not four so this memsets too much. Fortunately, this ends up corrupting a struct hole and not anything important.
Fixes d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")Signed-off-by Dan Carpenter <[email protected]>--- drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/xlnx/zynqmp_dp.c +0
-0@@ -866,7 +866,7 @@ static int zynqmp_dp_train(struct zynqmp_dp *dp)return ret;
Quoted 9 lines
drivers/gpu/drm/xlnx/zynqmp_dp.c static int zynqmp_dp_train(struct zynqmp_dp *dp) · line 872
Quoted 7 lines
drivers/gpu/drm/xlnx/zynqmp_dp.c +1
-1zynqmp_dp_write (dp,ZYNQMP_DP_SCRAMBLING_DISABLE ,1 ); -memset (dp->train_set,0 ,4 ); +memset (dp->train_set,0 ,sizeof (dp->train_set)); ret =zynqmp_dp_link_train_cr (dp);if (ret)return ret;Reviewed-by Michal Simek <[email protected]>
Stuffed into drm-misc-next, thanks.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel