Skip to contentSkip to conversation

PATCH Mitali Borkar 2 participants 2 messages Apr 5, 2021 – Apr 6, 2021 Staging

lore
Share & tools
lore
#0 lore raw

[email protected], [email protected] Bcc:
Subject: [PATCH] staging: qlge:remove else after break Reply-To:

Fixed Warning:- else is not needed after break
break terminates the loop if encountered. else is unnecessary and increases indenatation

---
 drivers/staging/qlge/qlge_mpi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/qlge/qlge_mpi.c +1 -3
index 2630ebf50341..3a49f187203b 100644
@@ -935,13 +935,11 @@ static int qlge_idc_wait(struct qlge_adapter *qdev)
 			netif_err(qdev, drv, qdev->ndev, "IDC Success.\n");
 			status = 0;
 			break;
-		} else {
-			netif_err(qdev, drv, qdev->ndev,
+		}	netif_err(qdev, drv, qdev->ndev,
 				  "IDC: Invalid State 0x%.04x.\n",
 				  mbcp->mbox_out[0]);
 			status = -EIO;
 			break;
-		}
 	}
 
 	return status;
Signature · 1 line
2.30.2
#1 lore raw
Quoted 22 lines · Mitali Borkar

[email protected], [email protected] Bcc:
Subject: [PATCH] staging: qlge:remove else after break Reply-To:

Fixed Warning:- else is not needed after break
break terminates the loop if encountered. else is unnecessary and increases indenatation

---
 drivers/staging/qlge/qlge_mpi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/qlge/qlge_mpi.c +0 -0
index 2630ebf50341..3a49f187203b 100644
@@ -935,13 +935,11 @@ static int qlge_idc_wait(struct qlge_adapter *qdev)
                        netif_err(qdev, drv, qdev->ndev, "IDC Success.\n");
                        status = 0;

drivers/staging/qlge/qlge_mpi.c static int qlge_idc_wait(struct qlge_adapter *qdev) · line 943

Quoted 10 lines
drivers/staging/qlge/qlge_mpi.c +1 -3
                        break;
-               } else {
-                       netif_err(qdev, drv, qdev->ndev,
+               }       netif_err(qdev, drv, qdev->ndev,
                                  "IDC: Invalid State 0x%.04x.\n",
                                  mbcp->mbox_out[0]);
                        status = -EIO;
                        break;
-               }
        }

It looks like you got this one wrong in multiple ways:

- This is not an equivalent transformation, since the errror is now printed in the first part of the 'if()' block as well.

- The indentation is wrong now, with the netif_err() starting in the same line as the '}'.

- The description mentions a change in indentation, but you did not actually change it.

- The changelog text appears mangled.

Arnd