Skip to contentSkip to conversation

staging: qlge: remove else after break

PATCH In review Mitali Borkar 3 participants 3 messages Apr 5, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: qlge: remove else after break

linux-staging@lists,[email protected] Bcc:
Subject: [PATCH] staging: qlge:remove else after break Reply-To:

Fixed Warning:- else is not needed after break
break terminates the loop if encountered. else is unnecessary and increases indenatation

---
 drivers/staging/qlge/qlge_mpi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/qlge/qlge_mpi.c +1 -3
index 2630ebf50341..3a49f187203b 100644
@@ -935,13 +935,11 @@ static int qlge_idc_wait(struct qlge_adapter *qdev)
 			netif_err(qdev, drv, qdev->ndev, "IDC Success.\n");
 			status = 0;
 			break;
-		} else {
-			netif_err(qdev, drv, qdev->ndev,
+		}	netif_err(qdev, drv, qdev->ndev,
 				  "IDC: Invalid State 0x%.04x.\n",
 				  mbcp->mbox_out[0]);
 			status = -EIO;
 			break;
-		}
 	}
 
 	return status;
Signature · 1 line
2.30.2
#1 lore raw

drivers/staging/qlge/qlge_mpi.c static int qlge_idc_wait(struct qlge_adapter *qdev) · line 938

Quoted 3 lines · Mitali Borkar
drivers/staging/qlge/qlge_mpi.c +1 -2
-		} else {
-			netif_err(qdev, drv, qdev->ndev,
+		}	netif_err(qdev, drv, qdev->ndev,

That's not the normal indentation style ... does checkpatch really not complain about that?

Quoted 15 lines
drivers/staging/qlge/qlge_mpi.c +0 -1
 				  "IDC: Invalid State 0x%.04x.\n",
 				  mbcp->mbox_out[0]);
 			status = -EIO;
 			break;
-		}
 	}
 
 	return status;
Signature · 6 lines
2.30.2

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YGpcx9MZuZJFy0Z/%40kali.
maintainer
#2 lore raw
In reply to Mitali Borkar
Quoted 4 lines · Mitali Borkar

linux-staging@lists,[email protected] Bcc:
Subject: [PATCH] staging: qlge:remove else after break Reply-To:

Very odd, why is this in the body of the email?

Quoted 16 lines

Fixed Warning:- else is not needed after break
break terminates the loop if encountered. else is unnecessary and increases indenatation

---
 drivers/staging/qlge/qlge_mpi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/qlge/qlge_mpi.c +0 -0
index 2630ebf50341..3a49f187203b 100644
@@ -935,13 +935,11 @@ static int qlge_idc_wait(struct qlge_adapter *qdev)
 			netif_err(qdev, drv, qdev->ndev, "IDC Success.\n");

drivers/staging/qlge/qlge_mpi.c static int qlge_idc_wait(struct qlge_adapter *qdev) · line 944

Quoted 10 lines
drivers/staging/qlge/qlge_mpi.c +1 -3
 			status = 0;
 			break;
-		} else {
-			netif_err(qdev, drv, qdev->ndev,
+		}	netif_err(qdev, drv, qdev->ndev,
 				  "IDC: Invalid State 0x%.04x.\n",
 				  mbcp->mbox_out[0]);
 			status = -EIO;
 			break;
-		}

Indentation is now no longer correct :(

thanks,

greg k-h