Skip to contentSkip to conversation

RDMA/cxgb4: check for ipv6 address properly while destroying listener

PATCH Applied Potnuri Bharat Teja 2 participants 3 messages Mar 31, 2021 – Apr 7, 2021

Subsystems (2)
lore
Share & tools
lore

Potnuri Bharat Teja

author maintainer
#0 lore raw

PATCH 1/1 RDMA/cxgb4: check for ipv6 address properly while destroying listener

ipv6 bit is wrongly set by commit '3408be145a5d' which causes fatal adapter lookup engine errors for ipv4 connections while destroying listener. Current patch properly checks the local address for ipv6 and fixes the blunder introduced by commit '3408be145a5d'.

Fixes 3408be145a5d ("RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server")
---
 drivers/infiniband/hw/cxgb4/cm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/infiniband/hw/cxgb4/cm.c +2 -1
index 81903749d241..e42c812e74c3 100644
@@ -3616,7 +3616,8 @@ int c4iw_destroy_listen(struct iw_cm_id *cm_id)
 		c4iw_init_wr_wait(ep->com.wr_waitp);
 		err = cxgb4_remove_server(
 				ep->com.dev->rdev.lldi.ports[0], ep->stid,
-				ep->com.dev->rdev.lldi.rxq_ids[0], true);
+				ep->com.dev->rdev.lldi.rxq_ids[0],
+				ep->com.local_addr.ss_family == AF_INET6);
 		if (err)
 			goto done;
 		err = c4iw_wait_for_reply(&ep->com.dev->rdev, ep->com.wr_waitp,
Signature · 1 line
2.24.0
author maintainer
#1 lore raw
Quoted 7 lines · Potnuri Bharat Teja

ipv6 bit is wrongly set by commit '3408be145a5d' which causes fatal adapter lookup engine errors for ipv4 connections while destroying listener. Current patch properly checks the local address for ipv6 and fixes the blunder introduced by commit '3408be145a5d'.

Fixes 3408be145a5d ("RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server")

Gentle reminder.

Quoted 21 lines
---
 drivers/infiniband/hw/cxgb4/cm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/infiniband/hw/cxgb4/cm.c +2 -1
index 81903749d241..e42c812e74c3 100644
@@ -3616,7 +3616,8 @@ int c4iw_destroy_listen(struct iw_cm_id *cm_id)
 		c4iw_init_wr_wait(ep->com.wr_waitp);
 		err = cxgb4_remove_server(
 				ep->com.dev->rdev.lldi.ports[0], ep->stid,
-				ep->com.dev->rdev.lldi.rxq_ids[0], true);
+				ep->com.dev->rdev.lldi.rxq_ids[0],
+				ep->com.local_addr.ss_family == AF_INET6);
 		if (err)
 			goto done;
 		err = c4iw_wait_for_reply(&ep->com.dev->rdev, ep->com.wr_waitp,
Signature · 1 line
2.24.0
maintainer Applied
#2 lore raw
In reply to Potnuri Bharat Teja
Quoted 10 lines · Potnuri Bharat Teja

ipv6 bit is wrongly set by commit '3408be145a5d' which causes fatal adapter lookup engine errors for ipv4 connections while destroying listener. Current patch properly checks the local address for ipv6 and fixes the blunder introduced by commit '3408be145a5d'.

Fixes 3408be145a5d ("RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server")
---
 drivers/infiniband/hw/cxgb4/cm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Applied to for-rc, thanks

Jason