Skip to contentSkip to conversation

staging: media: zoran: moved statement to next line with '*'

PATCH In review Mitali Borkar 2 participants 2 messages Apr 9, 2021 – Apr 13, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: media: zoran: moved statement to next line with '*'

Moved the statement to next line and added '*' before it to meet linux kernel coding style for long(multi-line) comments.

---

Changes from v1:- made style changes according to linux kernel coding style for long comments.

drivers/staging/media/zoran/zr36060.c | 3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/media/zoran/zr36060.c +2 -1
index 035634fc1c6d..8c6f4d792a9d 100644
@@ -249,7 +249,8 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 };	//table idx's AC
 static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
 static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };
 
-/* SOF (start of frame) segment depends on width,
+/*
+ * SOF (start of frame) segment depends on width,
  * height and sampling ratio of each color component
  */
 static int zr36060_set_sof(struct zr36060 *ptr)
Signature · 1 line
2.30.2
#1 lore raw
Quoted 18 lines · Mitali Borkar

Moved the statement to next line and added '*' before it to meet linux kernel coding style for long(multi-line) comments.

---

Changes from v1:- made style changes according to linux kernel coding style for long comments.

drivers/staging/media/zoran/zr36060.c | 3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/media/zoran/zr36060.c +0 -0
index 035634fc1c6d..8c6f4d792a9d 100644

drivers/staging/media/zoran/zr36060.c static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC · line 256

Quoted 9 lines
drivers/staging/media/zoran/zr36060.c +2 -1
@@ -249,7 +249,8 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 };	//table idx's AC
 static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
 static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };
 
-/* SOF (start of frame) segment depends on width,
+/*
+ * SOF (start of frame) segment depends on width,
  * height and sampling ratio of each color component
  */
 static int zr36060_set_sof(struct zr36060 *ptr)

Same problem as with other patches: this sits on top of your v1, so won't apply to mainline code.

Regards,

Hans