media: omap3isp: drop graph mutex on error path
Subsystems (2)
PATCH 1/1 media: omap3isp: drop graph mutex on error path
Drop the "&isp->media_dev.graph_mutex" if media_entity_enum_init() fails.
Fixes ba689d933361 ("media: omap3isp: Acquire graph mutex for graph traversal")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/media/platform/omap3isp/isp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/media/platform/omap3isp/isp.c +3 -1
@@ -2037,8 +2037,10 @@ static int isp_subdev_notifier_complete(struct v4l2_async_notifier *async)mutex_lock (&isp->media_dev.graph_mutex); ret =media_entity_enum_init (&isp->crashed, &isp->media_dev); -if (ret) +if (ret) { +mutex_unlock (&isp->media_dev.graph_mutex);return ret; + }list_for_each_entry (sd, &v4l2_dev->subdevs, list) {if (sd->notifier != &isp->notifier)
Signature · 1 line
2.30.2
Hi Dan,
Quoted 4 lines · Dan Carpenter
Drop the "
&isp->media_dev.graph_mutex" ifmedia_entity_enum_init()fails.Fixes ba689d933361 ("media: omap3isp: Acquire graph mutex for graph traversal")Signed-off-by Dan Carpenter <[email protected]>
Thanks for the fix.
I got another patch here earlier to fix the same bug so I've taken that instead:
<URL:https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/>
Signature · 3 lines
Kind regards, Sakari Ailus