Skip to contentSkip to conversation

staging: media: zoran: reduce length of a line

PATCH In review Mitali Borkar 2 participants 2 messages Apr 13, 2021 – Apr 15, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: media: zoran: reduce length of a line

Reduced length of a line which exceed the 100 columns limit by splitting the line into two statements and commenting it with '*' to meet linux kernel coding style for long(multi-line) comments.
Reported by checkpatch.

---

Changes from v2:- Rebased this patch and made changes against mainline code.
Changes from v1:- Made style changes according to linux kernel coding style for long comments.

 drivers/staging/media/zoran/zr36060.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/staging/media/zoran/zr36060.c +5 -1
index 4f9eb9ff2c42..27eec3446592 100644
@@ -249,7 +249,11 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 };	//table idx's AC
 static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
 static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };
 
-/* SOF (start of frame) segment depends on width, height and sampling ratio of each color component */
+/*
+ * SOF (start of frame) segment depends on width,
+ * height and sampling ratio of each color component
+ */
+
 static int zr36060_set_sof(struct zr36060 *ptr)
 {
 	char sof_data[34];	// max. size of register set
Signature · 1 line
2.30.2
#1 lore raw
Quoted 21 lines · Mitali Borkar

Reduced length of a line which exceed the 100 columns limit by splitting the line into two statements and commenting it with '*' to meet linux kernel coding style for long(multi-line) comments.
Reported by checkpatch.

---

Changes from v2:- Rebased this patch and made changes against mainline code.
Changes from v1:- Made style changes according to linux kernel coding style for long comments.

 drivers/staging/media/zoran/zr36060.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/staging/media/zoran/zr36060.c +0 -0
index 4f9eb9ff2c42..27eec3446592 100644

drivers/staging/media/zoran/zr36060.c static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC · line 256

Quoted 9 lines
drivers/staging/media/zoran/zr36060.c +5 -1
@@ -249,7 +249,11 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 };	//table idx's AC
 static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
 static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };
 
-/* SOF (start of frame) segment depends on width, height and sampling ratio of each color component */
+/*
+ * SOF (start of frame) segment depends on width,
+ * height and sampling ratio of each color component
+ */
+

No need for this extra newline. The comment block describes the function, so the function should directly follow that comment.

Regards,

Hans

Quoted 4 lines
drivers/staging/media/zoran/zr36060.c +0 -0
 static int zr36060_set_sof(struct zr36060 *ptr)
 {
 	char sof_data[34];	// max. size of register set