Revert "crypto: cavium/nitrox - add an error message to explain the failure of pci_request_mem_regions"
PATCH 1/1 Revert "crypto: cavium/nitrox - add an error message to explain the failure of pci_request_mem_regions"
This reverts commit 9fcddaf2e28d779cb946d23838ba6d50f299aa80 as it was submitted under a fake name and we can not knowingly accept anonymous contributions to the repository.
This commit was part of a submission "test" to the Linux kernel community by some "researchers" at umn.edu. As outlined at:
https://www-users.cs.umn.edu/%7Ekjlu/papers/full-disclosure.pdf
it was done so as an attempt to submit a known-buggy patch to see if it could get by our review. However, the submission turned out to actually be correct, and not have a bug in it as the author did not understand how the PCI driver model works at all, and so the submission was accepted.
As this change is of useless consequence, there is no loss of functionality in reverting it.
--- drivers/crypto/cavium/nitrox/nitrox_main.c | 1 - 1 file changed, 1 deletion(-)
Herbert, I will be taking this as part of my larger "revert buggy patch submissions from umn.edu" tree, so no need for you to take this in your tree at this point in time, I just wanted to give you a heads up as to what is happening here.
drivers/crypto/cavium/nitrox/nitrox_main.c +0 -1
@@ -442,7 +442,6 @@ static int nitrox_probe(struct pci_dev *pdev, err =pci_request_mem_regions (pdev, nitrox_driver_name);if (err) {pci_disable_device (pdev); -dev_err (&pdev->dev,"Failed to request mem regions!\n" );return err; }pci_set_master (pdev);
Signature · 1 line
2.31.1
Quoted 21 lines · Greg Kroah-Hartman
This reverts commit
9fcddaf2e28d779cb946d23838ba6d50f299aa80as it was submitted under a fake name and we can not knowingly accept anonymous contributions to the repository.This commit was part of a submission "test" to the Linux kernel community by some "researchers" at umn.edu. As outlined at:
https://www-users.cs.umn.edu/%7Ekjlu/papers/full-disclosure.pdf
it was done so as an attempt to submit a known-buggy patch to see if it could get by our review. However, the submission turned out to actually be correct, and not have a bug in it as the author did not understand how the PCI driver model works at all, and so the submission was accepted.As this change is of useless consequence, there is no loss of functionality in reverting it.
Cc Herbert Xu <[email protected]>Cc "David S. Miller" <[email protected]>Cc Christophe JAILLET <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 8 lines
--- drivers/crypto/cavium/nitrox/nitrox_main.c | 1 - 1 file changed, 1 deletion(-)Herbert, I will be taking this as part of my larger "revert buggy patch submissions from umn.edu" tree, so no need for you to take this in your tree at this point in time, I just wanted to give you a heads up as to what is happening here.
Thanks,
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Quoted 26 lines · Herbert Xu
Quoted 25 lines · Greg Kroah-Hartman
This reverts commit
9fcddaf2e28d779cb946d23838ba6d50f299aa80as it was submitted under a fake name and we can not knowingly accept anonymous contributions to the repository.This commit was part of a submission "test" to the Linux kernel community by some "researchers" at umn.edu. As outlined at:
https://www-users.cs.umn.edu/%7Ekjlu/papers/full-disclosure.pdf
it was done so as an attempt to submit a known-buggy patch to see if it could get by our review. However, the submission turned out to actually be correct, and not have a bug in it as the author did not understand how the PCI driver model works at all, and so the submission was accepted.As this change is of useless consequence, there is no loss of functionality in reverting it.
Cc Herbert Xu <[email protected]>Cc "David S. Miller" <[email protected]>Cc Christophe JAILLET <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- drivers/crypto/cavium/nitrox/nitrox_main.c | 1 - 1 file changed, 1 deletion(-)
Quoted 6 lines
Quoted 4 lines
Herbert, I will be taking this as part of my larger "revert buggy patch submissions from umn.edu" tree, so no need for you to take this in your tree at this point in time, I just wanted to give you a heads up as to what is happening here.
Acked-by Herbert Xu <[email protected]>
Wonderful, thanks for the review.
greg k-h