Skip to contentSkip to conversation

serial: 8250_dw: Add device HID for new AMD UART controller

PATCH In review Maximilian Luz 4 participants 4 messages May 12, 2021 – May 17, 2021

Subsystems (5)
Stable branch ACPI TTY layer and serial drivers Intel LPSS (Low Power SubSystem) drivers +1 more subsystems
lore
Share & tools
lore

Maximilian Luz

author
#0 lore raw

PATCH 1/1 serial: 8250_dw: Add device HID for new AMD UART controller

Add device HID AMDI0022 to the AMD UART controller driver match table and create a platform device for it. This controller can be found on Microsoft Surface Laptop 4 devices and seems similar enough that we can just copy the existing AMDI0020 entries.

Cc <[email protected]> # 5.10+
Tested-by Sachi King <[email protected]>
Signed-off-by Maximilian Luz <[email protected]>
---
 drivers/acpi/acpi_apd.c           | 1 +
 drivers/tty/serial/8250/8250_dw.c | 1 +
 2 files changed, 2 insertions(+)
drivers/acpi/acpi_apd.c +1 -0
index 0ec5b3f69112..6e02448d15d9 100644
@@ -226,6 +226,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
 	{ "AMDI0010", APD_ADDR(wt_i2c_desc) },
 	{ "AMD0020", APD_ADDR(cz_uart_desc) },
 	{ "AMDI0020", APD_ADDR(cz_uart_desc) },
+	{ "AMDI0022", APD_ADDR(cz_uart_desc) },
 	{ "AMD0030", },
 	{ "AMD0040", APD_ADDR(fch_misc_desc)},
 	{ "HYGO0010", APD_ADDR(wt_i2c_desc) },
drivers/tty/serial/8250/8250_dw.c +1 -0
index 9e204f9b799a..a3a0154da567 100644
@@ -714,6 +714,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
 	{ "APMC0D08", 0},
 	{ "AMD0020", 0 },
 	{ "AMDI0020", 0 },
+	{ "AMDI0022", 0 },
 	{ "BRCM2032", 0 },
 	{ "HISI0031", 0 },
 	{ },
Signature · 1 line
2.31.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Maximilian Luz

Add device HID AMDI0022 to the AMD UART controller driver match table and create a platform device for it. This controller can be found on Microsoft Surface Laptop 4 devices and seems similar enough that we can just copy the existing AMDI0020 entries.

Acked-by Andy Shevchenko <[email protected]> # for 8250_dw part
Quoted 35 lines
Cc <[email protected]> # 5.10+
Tested-by Sachi King <[email protected]>
Signed-off-by Maximilian Luz <[email protected]>
---
 drivers/acpi/acpi_apd.c           | 1 +
 drivers/tty/serial/8250/8250_dw.c | 1 +
 2 files changed, 2 insertions(+)
drivers/acpi/acpi_apd.c +1 -0
index 0ec5b3f69112..6e02448d15d9 100644
@@ -226,6 +226,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
        { "AMDI0010", APD_ADDR(wt_i2c_desc) },
        { "AMD0020", APD_ADDR(cz_uart_desc) },
        { "AMDI0020", APD_ADDR(cz_uart_desc) },
+       { "AMDI0022", APD_ADDR(cz_uart_desc) },
        { "AMD0030", },
        { "AMD0040", APD_ADDR(fch_misc_desc)},
        { "HYGO0010", APD_ADDR(wt_i2c_desc) },
drivers/tty/serial/8250/8250_dw.c +1 -1
index 9e204f9b799a..a3a0154da567 100644
@@ -714,6 +714,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
        { "APMC0D08", 0},
        { "AMD0020", 0 },
        { "AMDI0020", 0 },
+       { "AMDI0022", 0 },
        { "BRCM2032", 0 },
        { "HISI0031", 0 },
        { },
--

2.31.1

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Maximilian Luz
Quoted 9 lines · Maximilian Luz

Add device HID AMDI0022 to the AMD UART controller driver match table and create a platform device for it. This controller can be found on Microsoft Surface Laptop 4 devices and seems similar enough that we can just copy the existing AMDI0020 entries.

Cc <[email protected]> # 5.10+
Tested-by Sachi King <[email protected]>
Signed-off-by Maximilian Luz <[email protected]>
Acked-by Rafael J. Wysocki <[email protected]>

or please let me know if this needs to go in through ACPI (I'm assuming that it doesn't).

Quoted 30 lines
---
 drivers/acpi/acpi_apd.c           | 1 +
 drivers/tty/serial/8250/8250_dw.c | 1 +
 2 files changed, 2 insertions(+)
drivers/acpi/acpi_apd.c +1 -0
index 0ec5b3f69112..6e02448d15d9 100644
@@ -226,6 +226,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
        { "AMDI0010", APD_ADDR(wt_i2c_desc) },
        { "AMD0020", APD_ADDR(cz_uart_desc) },
        { "AMDI0020", APD_ADDR(cz_uart_desc) },
+       { "AMDI0022", APD_ADDR(cz_uart_desc) },
        { "AMD0030", },
        { "AMD0040", APD_ADDR(fch_misc_desc)},
        { "HYGO0010", APD_ADDR(wt_i2c_desc) },
drivers/tty/serial/8250/8250_dw.c +1 -1
index 9e204f9b799a..a3a0154da567 100644
@@ -714,6 +714,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
        { "APMC0D08", 0},
        { "AMD0020", 0 },
        { "AMDI0020", 0 },
+       { "AMDI0022", 0 },
        { "BRCM2032", 0 },
        { "HISI0031", 0 },
        { },
--
maintainer
#3 lore raw
Quoted 7 lines · Rafael J. Wysocki
Quoted 6 lines · Maximilian Luz

Add device HID AMDI0022 to the AMD UART controller driver match table and create a platform device for it. This controller can be found on Microsoft Surface Laptop 4 devices and seems similar enough that we can just copy the existing AMDI0020 entries.

Quoted 8 lines
Quoted 3 lines
Cc <[email protected]> # 5.10+
Tested-by Sachi King <[email protected]>
Signed-off-by Maximilian Luz <[email protected]>
Acked-by Rafael J. Wysocki <[email protected]>

or please let me know if this needs to go in through ACPI (I'm assuming that it doesn't).

I've already taken it in my tty tree :)

thanks,

greg k-h