Remove floppy and CDROM stress tests
cover Remove floppy and CDROM stress tests
Hi,
does anybody use these tests? Does anybody need to test froppy or CDROM (even on VM)?
Kind regards,
Petr
Petr Vorel (2):
io: Remove stress_floppy
io: Remove stress_cd
runtest/io_cd | 1 - runtest/io_floppy | 1 - testcases/kernel/io/stress_cd/.gitignore | 1 - testcases/kernel/io/stress_cd/Makefile | 25 - testcases/kernel/io/stress_cd/stress_cd.c | 244 - testcases/kernel/io/stress_floppy/.gitignore | 4 - testcases/kernel/io/stress_floppy/Makefile | 25 - .../io/stress_floppy/datafiles/Makefile | 31 - .../kernel/io/stress_floppy/datafiles/dd_file | 21441 ---------------- .../datafiles/dumpdir/.gitignore | 1 - .../stress_floppy/datafiles/dumpdir/1K_file | 19 - .../stress_floppy/datafiles/dumpdir/Makefile | 40 - .../datafiles/dumpdir/generate.sh | 22 - .../kernel/io/stress_floppy/stress_floppy | 264 - testscripts/diskio.sh | 37 - 15 files changed, 22156 deletions(-) delete mode 100644 runtest/io_cd delete mode 100644 runtest/io_floppy delete mode 100644 testcases/kernel/io/stress_cd/.gitignore delete mode 100644 testcases/kernel/io/stress_cd/Makefile delete mode 100644 testcases/kernel/io/stress_cd/stress_cd.c delete mode 100644 testcases/kernel/io/stress_floppy/.gitignore delete mode 100644 testcases/kernel/io/stress_floppy/Makefile delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/Makefile delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/dd_file delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/dumpdir/.gitignore delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/dumpdir/1K_file delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/dumpdir/Makefile delete mode 100755 testcases/kernel/io/stress_floppy/datafiles/dumpdir/generate.sh delete mode 100755 testcases/kernel/io/stress_floppy/stress_floppy delete mode 100755 testscripts/diskio.sh
Signature · 1 line
2.31.1
RFC PATCH 1/2 io: Remove stress_floppy
floppy disc are history, there probably aren't many people using it on newer kernel even on VM. Keeping outdated tests does not make much sense.
--- runtest/io_floppy | 1 - testcases/kernel/io/stress_floppy/.gitignore | 4 - testcases/kernel/io/stress_floppy/Makefile | 25 - .../io/stress_floppy/datafiles/Makefile | 31 - .../kernel/io/stress_floppy/datafiles/dd_file | 21441 ---------------- .../datafiles/dumpdir/.gitignore | 1 - .../stress_floppy/datafiles/dumpdir/1K_file | 19 - .../stress_floppy/datafiles/dumpdir/Makefile | 40 - .../datafiles/dumpdir/generate.sh | 22 - .../kernel/io/stress_floppy/stress_floppy | 264 - testscripts/diskio.sh | 8 +- 11 files changed, 1 insertion(+), 21855 deletions(-) delete mode 100644 runtest/io_floppy delete mode 100644 testcases/kernel/io/stress_floppy/.gitignore delete mode 100644 testcases/kernel/io/stress_floppy/Makefile delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/Makefile delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/dd_file delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/dumpdir/.gitignore delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/dumpdir/1K_file delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/dumpdir/Makefile delete mode 100755 testcases/kernel/io/stress_floppy/datafiles/dumpdir/generate.sh delete mode 100755 testcases/kernel/io/stress_floppy/stress_floppy
runtest/io_floppy deleted +0 -1
@@ -1 +0,0 @@ -stress_floppy stress_floppy
testcases/kernel/io/stress_floppy/.gitignore deleted +0 -4
@@ -1,4 +0,0 @@ -/1000K_file -/100K_file -/10K_file -/dumpdir/
testcases/kernel/io/stress_floppy/Makefile deleted +0 -25
@@ -1,25 +0,0 @@ -# -# Copyright (c) International Business Machines Corp., 2001 -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See -# the GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA -# - -top_srcdir ?= ../../../.. - -include $(top_srcdir)/include/mk/testcases.mk - -INSTALL_TARGETS := stress_floppy - -include $(top_srcdir)/include/mk/generic_trunk_target.mk
testcases/kernel/io/stress_floppy/datafiles/Makefile deleted +0 -31
@@ -1,31 +0,0 @@ -################################################################################ -## kernel/io/stress_floppy/datafiles Makefile. ## -## ## -## Copyright (c) International Business Machines Corp., 2001 ## -## Copyright (c) 2015 Fujitsu Ltd. ## -## ## -## This program is free software; you can redistribute it and/or modify ## -## it under the terms of the GNU General Public License as published by ## -## the Free Software Foundation; either version 2 of the License, or ## -## (at your option) any later version. ## -## ## -## This program is distributed in the hope that it will be useful, ## -## but WITHOUT ANY WARRANTY; without even the implied warranty of ## -## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the ## -## GNU General Public License for more details. ## -## ## -## You should have received a copy of the GNU General Public License along ## -## with this program; if not, write to the Free Software Foundation, Inc., ## -## 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. ## -## ## -################################################################################ - -top_srcdir ?= ../../../../.. - -include $(top_srcdir)/include/mk/env_pre.mk - -INSTALL_DIR := testcases/data/stress_floppy - -INSTALL_TARGETS := dd_file - -include $(top_srcdir)/include/mk/generic_trunk_target.mk
testcases/kernel/io/stress_floppy/datafiles/dd_file deleted +0 -21441
2,939 lines not on this page · raw message
testcases/kernel/io/stress_floppy/datafiles/dumpdir/.gitignore deleted +0 -1
Lines of this file are not shown. View the raw message.
testcases/kernel/io/stress_floppy/datafiles/dumpdir/1K_file deleted +0 -19
Lines of this file are not shown. View the raw message.
testcases/kernel/io/stress_floppy/datafiles/dumpdir/Makefile deleted +0 -40
Lines of this file are not shown. View the raw message.
testcases/kernel/io/stress_floppy/datafiles/dumpdir/generate.sh deleted +0 -22
Lines of this file are not shown. View the raw message.
testcases/kernel/io/stress_floppy/stress_floppy deleted +0 -264
264 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.31.1
Part of the diff is not shown here. View the raw message.
RFC PATCH 2/2 io: Remove stress_cd
In reply to Petr VorelSimilarly to previous commit, also CDROM / DVD aren't much used nowadays and thus it does not make much sense to keep and further cleanup stress_cd.c.
Remove also diskio.sh, which was used only for stress_{cd,floppy}.
--- runtest/io_cd | 1 - testcases/kernel/io/stress_cd/.gitignore | 1 - testcases/kernel/io/stress_cd/Makefile | 25 --- testcases/kernel/io/stress_cd/stress_cd.c | 244 ---------------------- testscripts/diskio.sh | 31 --- 5 files changed, 302 deletions(-) delete mode 100644 runtest/io_cd delete mode 100644 testcases/kernel/io/stress_cd/.gitignore delete mode 100644 testcases/kernel/io/stress_cd/Makefile delete mode 100644 testcases/kernel/io/stress_cd/stress_cd.c delete mode 100755 testscripts/diskio.sh
runtest/io_cd deleted +0 -1
@@ -1 +0,0 @@ -stress_cd stress_cd
testcases/kernel/io/stress_cd/.gitignore deleted +0 -1
@@ -1 +0,0 @@ -/stress_cd
testcases/kernel/io/stress_cd/Makefile deleted +0 -25
@@ -1,25 +0,0 @@ -# -# Copyright (c) International Business Machines Corp., 2001 -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See -# the GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA -# - -top_srcdir ?= ../../../.. - -include $(top_srcdir)/include/mk/testcases.mk - -LDLIBS += -lpthread - -include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/io/stress_cd/stress_cd.c deleted +0 -244
244 lines not on this page · raw message
testscripts/diskio.sh deleted +0 -31
@@ -1,31 +0,0 @@ -#!/bin/sh -# These tests require the corresponding media to be present: -# -# stress_cd: Requires ANY data CD with a minimum of 100MB of data. - -cd `dirname $0` - -export LTPROOT=${PWD} -echo $LTPROOT | grep testscripts > /dev/null 2>&1 -if [ $? -eq 0 ]; then - cd .. - export LTPROOT=${PWD} -fi - -export TMPDIR=/tmp - -mkdir /tmp/diskiopan-$$ -cd /tmp/diskiopan-$$ - -export PATH="${PATH}:${LTPROOT}/testcases/bin" - -${LTPROOT}/ver_linux - -${LTPROOT}/bin/ltp-pan -e -l /tmp/diskiopan.log -S -a ltpdiskio -n ltpdiskio -f ${LTPROOT}/runtest/io_cd - -if [ $? -eq "0" ]; then - echo ltp-pan reported PASS -else - echo ltp-pan reported FAIL -fi -
Signature · 1 line
2.31.1
cover Remove floppy and CDROM stress tests
In reply to Petr VorelQuoted 5 lines · Petr Vorel
Hi,
does anybody use these tests? Does anybody need to test froppy or CDROM (even on VM)?
I'm not, and I don't recall seeing this in any reports or issues, so I think they wouldn't be missed.
Quoted 44 lines
Kind regards,
PetrPetr Vorel (2):
io: Removestress_floppy
io: Removestress_cdruntest/io_cd | 1 - runtest/io_floppy | 1 - testcases/kernel/io/stress_cd/.gitignore | 1 - testcases/kernel/io/stress_cd/Makefile | 25 - testcases/kernel/io/stress_cd/stress_cd.c | 244 - testcases/kernel/io/stress_floppy/.gitignore | 4 - testcases/kernel/io/stress_floppy/Makefile | 25 - .../io/stress_floppy/datafiles/Makefile | 31 - .../kernel/io/stress_floppy/datafiles/dd_file | 21441 ---------------- .../datafiles/dumpdir/.gitignore | 1 - .../stress_floppy/datafiles/dumpdir/1K_file | 19 - .../stress_floppy/datafiles/dumpdir/Makefile | 40 - .../datafiles/dumpdir/generate.sh | 22 - .../kernel/io/stress_floppy/stress_floppy | 264 - testscripts/diskio.sh | 37 - 15 files changed, 22156 deletions(-) delete mode 100644 runtest/io_cd delete mode 100644 runtest/io_floppy delete mode 100644 testcases/kernel/io/stress_cd/.gitignore delete mode 100644 testcases/kernel/io/stress_cd/Makefile delete mode 100644 testcases/kernel/io/stress_cd/stress_cd.c delete mode 100644 testcases/kernel/io/stress_floppy/.gitignore delete mode 100644 testcases/kernel/io/stress_floppy/Makefile delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/Makefile delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/dd_file delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/dumpdir/.gitignore delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/dumpdir/1K_file delete mode 100644 testcases/kernel/io/stress_floppy/datafiles/dumpdir/Makefile delete mode 100755 testcases/kernel/io/stress_floppy/datafiles/dumpdir/generate.sh delete mode 100755 testcases/kernel/io/stress_floppy/stress_floppy delete mode 100755 testscripts/diskio.sh
Quoted 4 lines
--
2.31.1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20210608/46d4e7b6/attachment.htm>
cover Remove floppy and CDROM stress tests
Hi!
Acked by me as well, but let's wait at least till the end of week until we apply this.
Signature · 2 lines
Cyril Hrubis [email protected]
cover Remove floppy and CDROM stress tests
Quoted 3 lines
Hi!
Acked by me as well, but let's wait at least till the end of week until we apply this.
Sure, I can postpone the deletion till Monday. Thanks for your ack.
Kind regards,
Petr
cover Remove floppy and CDROM stress tests
Hi all,
Quoted 5 lines
Quoted 3 lines
Hi!
Acked by me as well, but let's wait at least till the end of week until we apply this.Sure, I can postpone the deletion till Monday. Thanks for your ack.
Merged. Thanks for your ack.
Kind regards,
Petr