sched/fair: Optimize select_idle_cpu
PATCH v2 1/1 sched/fair: Optimize select_idle_cpu
From: Cheng Jian <[email protected]>
commit 60588bfa223ff675b95f866249f90616613fbe31 upstream.
select_idle_cpu() will scan the LLC domain for idle CPUs, it's always expensive. so the next commit :
1ad3aaf3fcd2 ("sched/core: Implement new approach to scale select_idle_cpu()")
introduces a way to limit how many CPUs we scan.
But it consume some CPUs out of 'nr' that are not allowed for the task and thus waste our attempts. The function always return nr_cpumask_bits, and we can't find a CPU which our task is allowed to run.
Cpumask may be too big, similar to select_idle_core(), use per_cpu_ptr 'select_idle_mask' to prevent stack overflow.
--- kernel/sched/fair.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
kernel/sched/fair.c +4 -3
@@ -5779,6 +5779,7 @@ static inline int select_idle_smt(struct task_struct *p, struct sched_domain *sd*/ static int select_idle_cpu (struct task_struct *p,struct sched_domain *sd,int target) { +struct cpumask *cpus =this_cpu_cpumask_var_ptr (select_idle_mask);struct sched_domain *this_sd;u64 avg_cost, avg_idle;u64 time, cost;
@@ -5809,11 +5810,11 @@ static int select_idle_cpu(struct task_struct *p, struct sched_domain *sd, int t time =local_clock (); -for_each_cpu_wrap (cpu,sched_domain_span (sd), target) { +cpumask_and (cpus,sched_domain_span (sd), &p->cpus_allowed); + +for_each_cpu_wrap (cpu, cpus, target) {if (!--nr)return -1 ; -if (!cpumask_test_cpu (cpu, &p->cpus_allowed)) -continue ;if (idle_cpu (cpu))break ; }
Signature · 1 line
1.8.3.1
Greg KH
maintainerQuoted 28 lines · Yang Wei
From: Cheng Jian <[email protected]>
commit
60588bfa223ff675b95f866249f90616613fbe31upstream.
select_idle_cpu()will scan the LLC domain for idle CPUs, it's always expensive. so the next commit :
1ad3aaf3fcd2("sched/core: Implement new approach to scaleselect_idle_cpu()")introduces a way to limit how many CPUs we scan.
But it consume some CPUs out of 'nr' that are not allowed for the task and thus waste our attempts. The function always return
nr_cpumask_bits, and we can't find a CPU which our task is allowed to run.Cpumask may be too big, similar to
select_idle_core(), useper_cpu_ptr'select_idle_mask' to prevent stack overflow.Fixes 1ad3aaf3fcd2 ("sched/core: Implement new approach to scale select_idle_cpu()")Signed-off-by Cheng Jian <[email protected]>Signed-off-by Peter Zijlstra (Intel) <[email protected]>Reviewed-by Srikar Dronamraju <[email protected]>Reviewed-by Vincent Guittot <[email protected]>Reviewed-by Valentin Schneider <[email protected]>Signed-off-by Yang Wei <[email protected]>Tested-by Yang Wei <[email protected]>
Quoted 4 lines
--- kernel/sched/fair.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
Both now queued up, thanks.
greg k-h