scsi: iscsi: Drop suspend calls from ep_disconnect
Hello Mike Christie,
This is a semi-automatic email about new static checker warnings.
The patch 27e986289e73: "scsi: iscsi: Drop suspend calls from ep_disconnect" from May 25, 2021, leads to the following Smatch complaint:
drivers/scsi/qedi/qedi_iscsi.c:1669 qedi_clear_session_ctx()
warn: variable dereferenced before check 'conn' (see line 1666)
drivers/scsi/qedi/qedi_iscsi.c
1665 struct iscsi_conn *conn = session->leadconn;
1666 struct qedi_conn *qedi_conn = conn->dd_data;
^^^^^^^^^^^^^Dereference
1667
1668 if (iscsi_is_session_online(cls_sess)) {
1669 if (conn)
^^^^
This new NULL check is too late.
1670 iscsi_suspend_queue(conn); 1671 qedi_ep_disconnect(qedi_conn->iscsi_ep);
regards,
dan carpenter