Skip to contentSkip to conversation

fix pan/ltp-pan return values

PATCH New dongshijiang 2 participants 2 messages Jun 8, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix pan/ltp-pan return values

When performing an LTP test, if there are only "PASS" and "TCONF" in the test results, but "runltp" displays "INFO: ltp-pan reported all tests PASS", I think it should give something like "INFO: ltp-pan reported some "tests FAIL or TCONF" prompt.

---
 pan/ltp-pan.c | 2 +-
 runltp        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
pan/ltp-pan.c +1 -1
index 298072fe0..05690f7c9 100644
@@ -770,7 +770,7 @@ check_pids(struct tag_pgrp *running, int *num_active, int keep_active,
 					"child %d exited with status %d\n",
 					cpid, w);
 			--*num_active;
-			if (w != 0 && w != TCONF)
+			if (w != 0)
 				ret++;
 		} else if (WIFSTOPPED(stat_loc)) {	/* should never happen */
 			w = WSTOPSIG(stat_loc);
runltp +1 -1
index 4447da156..539e7800d 100755
@@ -811,7 +811,7 @@ EOF
       VALUE=0
       export LTP_EXIT_VALUE=0;
     else
-      echo "INFO: ltp-pan reported some tests FAIL"
+      echo "INFO: ltp-pan reported some tests FAIL or TCONF"
       VALUE=1
       export LTP_EXIT_VALUE=1;
     fi
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 fix pan/ltp-pan return values

Hi!
Can we please stop adding band aids over the broken-by-design runltp script and ltp-pan?

We are going to finally push runltp-ng into LTP git during this development cycle and finally deprecate ltp-pan, feel free to try it yourself:

https://github.com/metan-ucw/runltp-ng

Signature · 2 lines
Cyril Hrubis
[email protected]