Input: resistive-adc-touch - describe parameters in kernel doc
Subsystems (3)
PATCH v2 1/2 Input: resistive-adc-touch - describe parameters in kernel doc
Validation script is not happy:
resistive-adc-touch.c:53: warning: Function parameter or member 'x_plate_ohms' not described in 'grts_state' resistive-adc-touch.c:53: warning: Function parameter or member 'ch' not described in 'grts_state'
Describe parameters in kernel doc to make it happy.
--- drivers/input/touchscreen/resistive-adc-touch.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/input/touchscreen/resistive-adc-touch.c +3 -1
@@ -35,16 +35,18 @@ enum grts_ch_type {/** * struct grts_state - generic resistive touch screen information struct +* @x_plate_ohms: resistance of the X plate * @pressure_min: number representing the minimum for the pressure * @pressure: are we getting pressure info or not * @iio_chans: list of channels acquired * @iio_cb: iio_callback buffer for the data * @input: the input device structure that we register * @prop: touchscreen properties struct +* @ch: channels that are defined for the touchscreen */ struct grts_state { -u32 pressure_min;u32 x_plate_ohms; +u32 pressure_min;bool pressure;struct iio_channel *iio_chans;struct iio_cb_buffer *iio_cb;
Signature · 1 line
2.30.2
PATCH v2 2/2 Input: resistive-adc-touch - replace OF headers with proper ones
The driver is actually OF independent and doesn't need anything from OF (*). Replace OF headers with mod_devicetable.h and property.h.
*) use of of_match_ptr() is actually wrong here, since it may provoke
a compiler to warn about unused variable.
--- drivers/input/touchscreen/resistive-adc-touch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/input/touchscreen/resistive-adc-touch.c +3 -3
@@ -13,10 +13,10 @@#include <linux/input/touchscreen.h> #include <linux/iio/consumer.h> #include <linux/iio/iio.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> -#include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> +#include <linux/property.h> #define DRIVER_NAME "resistive-adc-touch"#define GRTS_DEFAULT_PRESSURE_MIN 50000
@@ -307,7 +307,7 @@ static struct platform_driver grts_driver = { .probe = grts_probe, .driver = { .name = DRIVER_NAME, - .of_match_table = of_match_ptr(grts_of_match), + .of_match_table = grts_of_match, }, };
Signature · 1 line
2.30.2
Re: [PATCH v2 2/2] Input: resistive-adc-touch - replace OF headers with proper ones
Quoted 7 lines · Andy Shevchenko
The driver is actually OF independent and doesn't need anything from OF (*). Replace OF headers with
mod_devicetable.handproperty.h.*) use of
of_match_ptr()is actually wrong here, since it may provoke
a compiler to warn about unused variable.Signed-off-by Andy Shevchenko <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry
Quoted 9 lines · Andy Shevchenko
Validation script is not happy:
resistive-adc-touch.c:53: warning: Function parameter or member '
x_plate_ohms' not described in 'grts_state' resistive-adc-touch.c:53: warning: Function parameter or member 'ch' not described in 'grts_state'Describe parameters in kernel doc to make it happy.
Fixes fb082cd59afa ("Input: resistive-adc-touch - add support for z1 and z2 channels")Signed-off-by Andy Shevchenko <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry