Backporting fix for #199981 to 4.19.y?

Hi there,

I'm running Debian Buster on an old Asus EeePC and I see the battery always at 100% when unplugged, with an estimated battery life of 4200 hours, no matter how long I've been using it without AC power.

I suspect this might be bug #201351, marked as duplicate of #199981 and fixed in 5.0-rc1. Would you please consider backporting it to the 4.19 LTS kernel?

Quoted 6 lines · Laurențiu Păncescu

Hi there,

I'm running Debian Buster on an old Asus EeePC and I see the battery always at 100% when unplugged, with an estimated battery life of 4200 hours, no matter how long I've been using it without AC power.

Quoted 3 lines

I suspect this might be bug #201351, marked as duplicate of #199981 and fixed in 5.0-rc1. Would you please consider backporting it to the 4.19 LTS kernel?

What specific commit in Linus's tree is this so we know what to backport?

Quoted 7 lines · Greg KH

Quoted 6 lines · Laurențiu Păncescu

Hi there,

I'm running Debian Buster on an old Asus EeePC and I see the battery always at 100% when unplugged, with an estimated battery life of 4200 hours, no matter how long I've been using it without AC power.

Quoted 6 lines

Quoted 3 lines

I suspect this might be bug #201351, marked as duplicate of #199981 and fixed in 5.0-rc1. Would you please consider backporting it to the 4.19 LTS kernel?

What specific commit in Linus's tree is this so we know what to backport?

Hi Greg,

I think it's commit b1c0330823fe842dbb34641f1410f0afa51c29d3.

Many thanks,
Laurențiu

That commit does not apply cleanly and I need a backported version. Can you do that and test it to verify it works and then send it to us to be applied?

Hi Greg,

Quoted 3 lines · Greg KH

That commit does not apply cleanly and I need a backported version. Can you do that and test it to verify it works and then send it to us to be applied?

I now have a patch against linux-4.19.y, tested on my EeePC just now: the battery status and discharge rate are shown correctly.

I've never submitted a patch before, should I put "commit <short-hash> upstream." as the first line of my commit message, followed by another line stating which branch I would like this to be merged to? Should I also include the original commit message of the backported commit? And then use git format-patch? I just read through [1] and [2], but they don't say anything specific about commit messages for backported patches.

Quoted 10 lines · Laurențiu Păncescu

Hi Greg,

Quoted 3 lines · Greg KH

That commit does not apply cleanly and I need a backported version. Can you do that and test it to verify it works and then send it to us to be applied?

I now have a patch against linux-4.19.y, tested on my EeePC just now: the battery status and discharge rate are shown correctly.

Quoted 6 lines

I've never submitted a patch before, should I put "commit <short-hash> upstream." as the first line of my commit message, followed by another line stating which branch I would like this to be merged to? Should I also include the original commit message of the backported commit? And then use git format-patch? I just read through [1] and [2], but they don't say anything specific about commit messages for backported patches.

Yes, what you describe here should be great. Look at the stable mailing list archives on lore.kernel.org for other examples of this happening,
https://lore.kernel.org/r/[email protected] is one example.

Instead of doing a specific backport, maybe it is enough to pick a46393c02c76 ("ACPI: probe ECDT before loading AML tables regardless of module-level code flag") frst on 4.19.y and then the mentioned fix b1c0330823fe ("ACPI: EC: Look for ECDT EC after calling acpi_load_tables()").

Hi Laurențiu, Greg,

Quoted 18 lines · Greg KH

Quoted 10 lines · Laurențiu Păncescu

Hi Greg,

Quoted 3 lines · Greg KH

That commit does not apply cleanly and I need a backported version. Can you do that and test it to verify it works and then send it to us to be applied?

I now have a patch against linux-4.19.y, tested on my EeePC just now: the battery status and discharge rate are shown correctly.

Quoted 6 lines

I've never submitted a patch before, should I put "commit <short-hash> upstream." as the first line of my commit message, followed by another line stating which branch I would like this to be merged to? Should I also include the original commit message of the backported commit? And then use git format-patch? I just read through [1] and [2], but they don't say anything specific about commit messages for backported patches.

Quoted 4 lines

Yes, what you describe here should be great. Look at the stable mailing list archives on lore.kernel.org for other examples of this happening,
https://lore.kernel.org/r/[email protected] is one example.

Instead of doing a specific backport, maybe it is enough to pick a46393c02c76 ("ACPI: probe ECDT before loading AML tables regardless of module-level code flag") frst on 4.19.y and then the mentioned fix b1c0330823fe ("ACPI: EC: Look for ECDT EC after calling acpi_load_tables()").

I do not see a commit a46393c02c76 in Linus's tree :(

Are you sure these ids are correct?

Hi Greg,

Quoted 3 lines · Greg KH

I do not see a commit a46393c02c76 in Linus's tree :(

Are you sure these ids are correct?

Sorry for the confusion, I think the correct ids are d737f333b211361b6e239fc753b84c3be2634aaa and b1c0330823fe842dbb34641f1410f0afa51c29d3.