Skip to contentSkip to conversation

leds: leds-is31fl32xx: fix an error in is31fl32xx_parse_dt()

PATCH In review Dan Carpenter 2 participants 2 messages Jun 5, 2021 – Jun 7, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: leds-is31fl32xx: fix an error in is31fl32xx_parse_dt()

Return -EBUSY if the data is already in use (instead of returning success).

Fixes 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers")

---
Not tested. It prints an error so the intention seems clear, but sometimes making stuff a failure instead of a success can lead to unexpected problems in production. On the other hand, if this is not an error then shouldn't we do a continue instead of a goto err?

 drivers/leds/leds-is31fl32xx.c | 1 +
 1 file changed, 1 insertion(+)
drivers/leds/leds-is31fl32xx.c +1 -0
index 3b55af9a8c58..e6f34464914f 100644
@@ -386,6 +386,7 @@ static int is31fl32xx_parse_dt(struct device *dev,
 			dev_err(dev,
 				"Node %pOF 'reg' conflicts with another LED\n",
 				child);
+			ret = -EBUSY;
 			goto err;
 		}
 
Signature · 1 line
2.30.2
#1 lore raw
Quoted 10 lines · On Sat, 5 Jun 2021 15:49:10 +0300 Dan Carpenter <[email protected]>…

Return -EBUSY if the data is already in use (instead of returning success).

Fixes 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers")

---
Not tested. It prints an error so the intention seems clear, but sometimes making stuff a failure instead of a success can lead to unexpected problems in production. On the other hand, if this is not an error then shouldn't we do a continue instead of a goto err?

I originally had it continue (and ignore that LED), but during review Jacek commented [1] that he preferred it to be an error condition instead. It should be noted that this condition involves an invalid
devicetree: two (or more) LED sub-nodes on the same controller that specify the same controller channel number. FYI, the error message originally had a bit more detail which might make that more obvious, but it was simplified as part of another cleanup [2].

In any event, the end result is that the whole controller will fail to probe, and none of it's LEDs will be available. Because it's not a temporary condition, I don't think -EBUSY is the appropriate return value.
There happened to be another patch recently that used -EINVAL [3], which I think is more appropriate.

[1] https://lore.kernel.org/linux-leds/[email protected]/
[2] https://lore.kernel.org/linux-leds/[email protected]/
[2] https://lore.kernel.org/linux-leds/1622545743-21240-1-git-send-email-jiapeng.chong@linux.alibaba.com/

Quoted 16 lines
 drivers/leds/leds-is31fl32xx.c | 1 +
 1 file changed, 1 insertion(+)
drivers/leds/leds-is31fl32xx.c +1 -0
index 3b55af9a8c58..e6f34464914f 100644
@@ -386,6 +386,7 @@ static int is31fl32xx_parse_dt(struct device *dev,
 			dev_err(dev,
 				"Node %pOF 'reg' conflicts with another LED\n",
 				child);
+			ret = -EBUSY;
 			goto err;
 		}