Skip to contentSkip to conversation

configure: map x32 to cpu_family x86_64 for meson

PATCH Applied David Michael 4 participants 6 messages Jun 9, 2021 – Jun 11, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: map x32 to cpu_family x86_64 for meson

The meson.build file defines supported_cpus which does not contain x32, and x32 is not one of meson's stable built-in values:
https://mesonbuild.com/Reference-tables.html#cpu-families

---

Hi,

QEMU fails to build for x32 due to that cpu_family not being defined in supported_cpus. Can something like this be applied?

Alternatively, maybe it could be added to supported_cpus and accepted everywhere that matches x86 in meson.build, but upstream meson does not define a CPU type for x32.

Thanks.

David

 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index 8dcb9965b2..4478f3889a 100755
@@ -6384,7 +6384,7 @@ if test "$skip_meson" = no; then
         i386)
             echo "cpu_family = 'x86'" >> $cross
             ;;
-        x86_64)
+        x86_64|x32)
             echo "cpu_family = 'x86_64'" >> $cross
             ;;
         ppc64le)
Signature · 1 line
2.31.1
#1 lore raw
Quoted 7 lines · David Michael

The meson.build file defines supported_cpus which does not contain x32, and x32 is not one of meson's stable built-in values:
https://mesonbuild.com/Reference-tables.html#cpu-families

---

Quoted 8 lines

Hi,

QEMU fails to build for x32 due to that cpu_family not being defined in supported_cpus. Can something like this be applied?

Alternatively, maybe it could be added to supported_cpus and accepted everywhere that matches x86 in meson.build, but upstream meson does not define a CPU type for x32.

"supported_cpus" serves two distinct purposes in meson.build

- Identifies whether TCG supports the target
- Identifies whether QEMU maintainers consider the target supported

The change proposed below makes x32 be treated the same as x86_64.

Maybe that's right for the question of TCG support, but I'm less sure it is right from POV of QEMU maintainers expectations around the x32 target status. AFAIK, we don't have any CI for x32 and IIUC no maintainers are actively testing it manually, so it ought to be in the unsupported category.

Quoted 8 lines
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -0
index 8dcb9965b2..4478f3889a 100755

configure if test "$skip_meson" = no; then · line 6390

Quoted 8 lines
configure +1 -1
@@ -6384,7 +6384,7 @@ if test "$skip_meson" = no; then
         i386)
             echo "cpu_family = 'x86'" >> $cross
             ;;
-        x86_64)
+        x86_64|x32)
             echo "cpu_family = 'x86_64'" >> $cross
             ;;
         ppc64le)

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#2 lore raw
Quoted 22 lines · Daniel P. Berrangé
Quoted 7 lines · David Michael

The meson.build file defines supported_cpus which does not contain x32, and x32 is not one of meson's stable built-in values:
https://mesonbuild.com/Reference-tables.html#cpu-families

---

Quoted 8 lines

Hi,

QEMU fails to build for x32 due to that cpu_family not being defined in supported_cpus. Can something like this be applied?

Alternatively, maybe it could be added to supported_cpus and accepted everywhere that matches x86 in meson.build, but upstream meson does not define a CPU type for x32.

"supported_cpus" serves two distinct purposes in meson.build

- Identifies whether TCG supports the target
- Identifies whether QEMU maintainers consider the target supported

Quoted 7 lines

The change proposed below makes x32 be treated the same as x86_64.

Maybe that's right for the question of TCG support, but I'm less sure it is right from POV of QEMU maintainers expectations around the x32 target status. AFAIK, we don't have any CI for x32 and IIUC no maintainers are actively testing it manually, so it ought to be in the unsupported category.

Okay, then can something be done to change this line?

https://gitlab.com/qemu-project/qemu/-/blob/master/meson.build#L247

It's what causes the build to fail if it doesn't force the interpreter due to x32 not being in supported_cpus, but then the following (unreachable) code expects that x32 is not using the interpreter.

https://gitlab.com/qemu-project/qemu/-/blob/master/meson.build#L263

Thanks.

David

#3 lore raw
In reply to Daniel P. Berrangé
Quoted 18 lines · Daniel P. Berrangé
Quoted 7 lines · David Michael

The meson.build file defines supported_cpus which does not contain x32, and x32 is not one of meson's stable built-in values:
https://mesonbuild.com/Reference-tables.html#cpu-families

---

Quoted 8 lines

Hi,

QEMU fails to build for x32 due to that cpu_family not being defined in supported_cpus. Can something like this be applied?

Alternatively, maybe it could be added to supported_cpus and accepted everywhere that matches x86 in meson.build, but upstream meson does not define a CPU type for x32.

Quoted 6 lines

"supported_cpus" serves two distinct purposes in meson.build

- Identifies whether TCG supports the target
- Identifies whether QEMU maintainers consider the target supported

The change proposed below makes x32 be treated the same as x86_64.

I feel like it's more "fixing a regression we introduced by accident at some point". Looking at the 5.1 configure script (which predates the meson conversion) x32 is marked as a supported cpu. Currently it isn't, so that's a regression. (I don't have the setup to bisect that right now, but it would be interesting to confirm where it stopped working.) Whether we feel that we no longer want to support x32 is a separate question and we'd need to go through our usual deprecation process if we did want to drop it.

thanks
-- PMM

#4 lore raw
Quoted 26 lines · Peter Maydell
Quoted 18 lines · Daniel P. Berrangé
Quoted 7 lines · David Michael

The meson.build file defines supported_cpus which does not contain x32, and x32 is not one of meson's stable built-in values:
https://mesonbuild.com/Reference-tables.html#cpu-families

---

Quoted 8 lines

Hi,

QEMU fails to build for x32 due to that cpu_family not being defined in supported_cpus. Can something like this be applied?

Alternatively, maybe it could be added to supported_cpus and accepted everywhere that matches x86 in meson.build, but upstream meson does not define a CPU type for x32.

Quoted 6 lines

"supported_cpus" serves two distinct purposes in meson.build

- Identifies whether TCG supports the target
- Identifies whether QEMU maintainers consider the target supported

The change proposed below makes x32 be treated the same as x86_64.

Quoted 8 lines

I feel like it's more "fixing a regression we introduced by accident at some point". Looking at the 5.1 configure script (which predates the meson conversion) x32 is marked as a supported cpu. Currently it isn't, so that's a regression. (I don't have the setup to bisect that right now, but it would be interesting to confirm where it stopped working.) Whether we feel that we no longer want to support x32 is a separate question and we'd need to go through our usual deprecation process if we did want to drop it.

Ah, I missed that it was previously working.

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#5 lore raw
In reply to David Michael
Quoted 12 lines · David Michael

The meson.build file defines supported_cpus which does not contain x32, and x32 is not one of meson's stable built-in values:
https://mesonbuild.com/Reference-tables.html#cpu-families

---

Hi,

QEMU fails to build for x32 due to that cpu_family not being defined in supported_cpus. Can something like this be applied?

Quoted 7 lines

Alternatively, maybe it could be added to supported_cpus and accepted everywhere that matches x86 in meson.build, but upstream meson does not define a CPU type for x32.

Thanks.

David

Queued, thanks.

Paolo

Quoted 17 lines
  configure | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index 8dcb9965b2..4478f3889a 100755
@@ -6384,7 +6384,7 @@ if test "$skip_meson" = no; then
          i386)
              echo "cpu_family = 'x86'" >> $cross
              ;;
-        x86_64)
+        x86_64|x32)
              echo "cpu_family = 'x86_64'" >> $cross
              ;;
          ppc64le)