common_timers: define NSEC_PER_SEC as long long to avoid overflow on 32-bit
PATCH 1/1 common_timers: define NSEC_PER_SEC as long long to avoid overflow on 32-bit
When multiplying 30 with NSEC_PER_SEC, the result would overflow on 32-bit platforms, unless there was promotion to long long, which is what tst_ts_from_ns expects.
futex_wake04, which uses that, would end up getting EINVAL when calling futex, because timespec_valid would fail, as tv_nsec would have an invalid value.
After this change, futex_wake04 passes on i386.
Reported-by Po-Hsu Lin <[email protected]>
Suggested-by Cyril Hrubis <[email protected]>
Signed-off-by Thadeu Lima de Souza Cascardo <[email protected]>
--- include/lapi/common_timers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/lapi/common_timers.h +1 -1
@@ -12,7 +12,7 @@#include "lapi/posix_clocks.h" #ifndef NSEC_PER_SEC -#define NSEC_PER_SEC (1000000000L) +#define NSEC_PER_SEC (1000000000LL)#endif static const clock_t clock_list[] = {
Signature · 1 line
2.30.2
PATCH 1/1 common_timers: define NSEC_PER_SEC as long long to avoid overflow on 32-bit
Hi!
Pushed, thanks.
Signature · 2 lines
Cyril Hrubis [email protected]