Skip to contentSkip to conversation

pinctrl: mcp23s08: missing unlock in mcp23s08_irq()

PATCH In review Dan Carpenter 2 participants 2 messages Jun 10, 2021 – Jun 11, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: mcp23s08: missing unlock in mcp23s08_irq()

This code needs to drop the lock before returning.

Fixes 897120d41e7a ("pinctrl: mcp23s08: fix race condition in irq handler")
---
 drivers/pinctrl/pinctrl-mcp23s08.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/pinctrl-mcp23s08.c +1 -1
index 799d596a1a4b..d0259577934e 100644
@@ -353,7 +353,7 @@ static irqreturn_t mcp23s08_irq(int irq, void *data)
 
 	if (intf == 0) {
 		/* There is no interrupt pending */
-		return IRQ_HANDLED;
+		goto unlock;
 	}
 
 	if (mcp_read(mcp, MCP_INTCAP, &intcap))
Signature · 1 line
2.30.2
#1 lore raw
Quoted 4 lines · Dan Carpenter

This code needs to drop the lock before returning.

Fixes 897120d41e7a ("pinctrl: mcp23s08: fix race condition in irq handler")

Zhou Wei already sent an identical patch but thanks anyway!

Yours,
Linus Walleij