Skip to contentSkip to conversation

newlib_tests: Fix build dependency on lib

PATCH New Petr Vorel 2 participants 3 messages Jun 10, 2021

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH 1/1 newlib_tests: Fix build dependency on lib

this fixes build error:

$ cd lib && make clean && cd newlib_tests && make
ld: cannot find -lltp
Fixes bbdb9f783 ("lib: Add new test library API")
---
 lib/newlib_tests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/newlib_tests/Makefile +1 -1
index 30ca6810c..a263d7db5 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 top_srcdir		?= ../..
 
-include $(top_srcdir)/include/mk/env_pre.mk
+include $(top_srcdir)/include/mk/testcases.mk
 
 CFLAGS			+= -W -Wall
 LDLIBS			+= -lltp
Signature · 1 line
2.31.1
#1 lore raw

PATCH 1/1 newlib_tests: Fix build dependency on lib

Hi!

Quoted 17 lines

this fixes build error:

$ cd lib && make clean && cd newlib_tests && make
ld: cannot find -lltp
Fixes bbdb9f783 ("lib: Add new test library API")
---
 lib/newlib_tests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/newlib_tests/Makefile +0 -0
index 30ca6810c..a263d7db5 100644

lib/newlib_tests/Makefile line 4

Quoted 5 lines
lib/newlib_tests/Makefile +1 -1
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 top_srcdir		?= ../..
 
-include $(top_srcdir)/include/mk/env_pre.mk
+include $(top_srcdir)/include/mk/testcases.mk

Ah right, this adds dependency on the library and builds it if needed.

Btw the lib/tests/ subdirectory has the same problem, but I'm not sure if we care enough to fix that...

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#2 lore raw

PATCH 1/1 newlib_tests: Fix build dependency on lib

Hi Cyril,

...

Quoted 9 lines

lib/newlib_tests/Makefile line 4

Quoted 2 lines
lib/newlib_tests/Makefile +1 -1
-include $(top_srcdir)/include/mk/env_pre.mk
+include $(top_srcdir)/include/mk/testcases.mk

Ah right, this adds dependency on the library and builds it if needed.

Btw the lib/tests/ subdirectory has the same problem, but I'm not sure if we care enough to fix that...

Good catch, I fixed it here and merged.

Kind regards,
Petr