Skip to contentSkip to conversation

blk-mq: update hctx->dispatch_busy in case of real scheduler

PATCH In review Ming Lei 1 participant 2 messages Jun 4, 2021 – Jun 14, 2021 Block layer

lore
Share & tools
lore

Ming Lei

author
#0 lore raw

PATCH v2 1/1 blk-mq: update hctx->dispatch_busy in case of real scheduler

Commit 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io") starts to support io batching submission by using hctx->dispatch_busy.

However, blk_mq_update_dispatch_busy() isn't changed to update hctx->dispatch_busy in that commit, so fix the issue by updating hctx->dispatch_busy in case of real scheduler.

Fixes 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io")
---
 block/blk-mq.c | 3 ---
 1 file changed, 3 deletions(-)
block/blk-mq.c +0 -3
index 4261adee9964..5af4f099cdb0 100644
@@ -1224,9 +1224,6 @@ static void blk_mq_update_dispatch_busy(struct blk_mq_hw_ctx *hctx, bool busy)
 {
 	unsigned int ewma;
 
-	if (hctx->queue->elevator)
-		return;
-
 	ewma = hctx->dispatch_busy;
 
 	if (!ewma && !busy)
Signature · 1 line
2.31.1
author
#1 lore raw
Quoted 11 lines · Ming Lei

Commit 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io") starts to support io batching submission by using hctx->dispatch_busy.

However, blk_mq_update_dispatch_busy() isn't changed to update hctx->dispatch_busy in that commit, so fix the issue by updating hctx->dispatch_busy in case of real scheduler.

Fixes 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io")

Hello Jens,

Can you merge this patch if you are fine?

thanks,
Ming