Skip to contentSkip to conversation

apci: sysfs: Fixed void function style code issues

PATCH Applied Clayton Casciato 2 participants 3 messages Jun 12, 2021 – Jun 16, 2021 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 apci: sysfs: Fixed void function style code issues

Fixed coding style issues.

---
 drivers/acpi/sysfs.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/acpi/sysfs.c +0 -8
index d25927195d6d..d6626aba4a6a 100644
@@ -582,8 +582,6 @@ static void delete_gpe_attr_array(void)
 		kfree(counter_attrs);
 	}
 	kfree(all_attrs);
-
-	return;
 }
 
 static void gpe_count(u32 gpe_number)
@@ -598,8 +596,6 @@ static void gpe_count(u32 gpe_number)
 	else
 		all_counters[num_gpes + ACPI_NUM_FIXED_EVENTS +
 			     COUNT_ERROR].count++;
-
-	return;
 }
 
 static void fixed_event_count(u32 event_number)
@@ -612,8 +608,6 @@ static void fixed_event_count(u32 event_number)
 	else
 		all_counters[num_gpes + ACPI_NUM_FIXED_EVENTS +
 			     COUNT_ERROR].count++;
-
-	return;
 }
 
 static void acpi_global_event_handler(u32 event_type, acpi_handle device,
@@ -914,8 +908,6 @@ static void __exit interrupt_stats_exit(void)
 	sysfs_remove_group(acpi_kobj, &interrupt_stats_attr_group);
 
 	delete_gpe_attr_array();
-
-	return;
 }
 
 static ssize_t
Signature · 1 line
2.31.1
maintainer Applied
#1 lore raw
Quoted 40 lines · Clayton Casciato

Fixed coding style issues.

---
 drivers/acpi/sysfs.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/acpi/sysfs.c +0 -6
index d25927195d6d..d6626aba4a6a 100644
@@ -582,8 +582,6 @@ static void delete_gpe_attr_array(void)
                kfree(counter_attrs);
        }
        kfree(all_attrs);
-
-       return;
 }
 
 static void gpe_count(u32 gpe_number)
@@ -598,8 +596,6 @@ static void gpe_count(u32 gpe_number)
        else
                all_counters[num_gpes + ACPI_NUM_FIXED_EVENTS +
                             COUNT_ERROR].count++;
-
-       return;
 }
 
 static void fixed_event_count(u32 event_number)
@@ -612,8 +608,6 @@ static void fixed_event_count(u32 event_number)
        else
                all_counters[num_gpes + ACPI_NUM_FIXED_EVENTS +
                             COUNT_ERROR].count++;
-
-       return;
 }
 
 static void acpi_global_event_handler(u32 event_type, acpi_handle device,

drivers/acpi/sysfs.c static void __exit interrupt_stats_exit(void)

Quoted 9 lines
drivers/acpi/sysfs.c +0 -3
@@ -914,8 +908,6 @@ static void __exit interrupt_stats_exit(void)
        sysfs_remove_group(acpi_kobj, &interrupt_stats_attr_group);
 
        delete_gpe_attr_array();
-
-       return;
 }
 
 static ssize_t
--

Applied as 5.14 material with edited subject and changelog.

Thanks!

#2 lore raw
Quoted 49 lines · Rafael J. Wysocki
Quoted 47 lines · Clayton Casciato

Fixed coding style issues.

---
 drivers/acpi/sysfs.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/acpi/sysfs.c +0 -8
index d25927195d6d..d6626aba4a6a 100644
@@ -582,8 +582,6 @@ static void delete_gpe_attr_array(void)
                kfree(counter_attrs);
        }
        kfree(all_attrs);
-
-       return;
 }
 
 static void gpe_count(u32 gpe_number)
@@ -598,8 +596,6 @@ static void gpe_count(u32 gpe_number)
        else
                all_counters[num_gpes + ACPI_NUM_FIXED_EVENTS +
                             COUNT_ERROR].count++;
-
-       return;
 }
 
 static void fixed_event_count(u32 event_number)
@@ -612,8 +608,6 @@ static void fixed_event_count(u32 event_number)
        else
                all_counters[num_gpes + ACPI_NUM_FIXED_EVENTS +
                             COUNT_ERROR].count++;
-
-       return;
 }
 
 static void acpi_global_event_handler(u32 event_type, acpi_handle device,
@@ -914,8 +908,6 @@ static void __exit interrupt_stats_exit(void)
        sysfs_remove_group(acpi_kobj, &interrupt_stats_attr_group);
 
        delete_gpe_attr_array();
-
-       return;
 }
 
Quoted 6 lines

drivers/acpi/sysfs.c static void __exit interrupt_stats_exit(void)

Quoted 2 lines
drivers/acpi/sysfs.c +0 -1
 static ssize_t
--

Applied as 5.14 material with edited subject and changelog.

Thanks!

I'm not sure how to find the edits.
Did you note them for transparency or would you recommend I do something different in the future?

These are my first patches and any feedback you'd be willing to provide would be appreciated.

Thank you, Rafael!