scsi: elx: libefc: signedness bug in efc_d_send_prli_rsp()
PATCH 1/1 scsi: elx: libefc: signedness bug in efc_d_send_prli_rsp()
The "rc" variable needs to be signed for the error handling to work. It holds either a negative error code, EFC_SCSI_CALL_COMPLETE (0), or EFC_SCSI_CALL_ASYNC (1).
Fixes 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/scsi/elx/libefc/efc_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/elx/libefc/efc_device.c +1 -1
@@ -15,7 +15,7 @@void efc_d_send_prli_rsp (struct efc_node *node,u16 ox_id) { -u32 rc =EFC_SCSI_CALL_COMPLETE ; +int rc =EFC_SCSI_CALL_COMPLETE ;struct efc *efc = node->efc; node->ls_acc_oxid = ox_id;
Signature · 1 line
2.30.2
Quoted 10 lines · Dan Carpenter
The "rc" variable needs to be signed for the error handling to work. It holds either a negative error code,
EFC_SCSI_CALL_COMPLETE(0), orEFC_SCSI_CALL_ASYNC(1).Fixes 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling")Signed-off-by Dan Carpenter <[email protected]>--- drivers/scsi/elx/libefc/efc_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks!
Reviewed-by James Smart <[email protected]>
-- james