drm/i915/gt: Fix -EDEADLK handling regression
Subsystems (3)
PATCH 1/1 drm/i915/gt: Fix -EDEADLK handling regression
From: Ville Syrjälä <[email protected]>
The conversion to ww mutexes failed to address the fence code which already returns -EDEADLK when we run out of fences. Ww mutexes on the other hand treat -EDEADLK as an internal errno value indicating a need to restart the operation due to a deadlock. So now when the fence code returns -EDEADLK the higher level code erroneously restarts everything instead of returning the error to userspace as is expected.
To remedy this let's switch the fence code to use a different errno value for this. -ENOBUFS seems like a semi-reasonable unique choice. Apart from igt the only user of this I could find is sna, and even there all we do is dump the current fence registers from debugfs into the X server log. So no user visible functionality is affected. If we really cared about preserving this we could of course convert back to -EDEADLK higher up, but doesn't seem like that's worth the hassle here.
Not quite sure which commit specifically broke this, but I'll just attribute it to the general gem ww mutex work.
Cc: [email protected]
Cc: Maarten Lankhorst <[email protected]>
Cc: Thomas Hellström <[email protected]>
Testcase: igt/gem_pread/exhaustion
Testcase: igt/gem_pwrite/basic-exhaustion
Testcase: igt/gem_fenced_exec_thrash/too-many-fences
--- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +1 -1
@@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt)if (intel_has_pending_fb_unpin (ggtt->vm.i915))return ERR_PTR (-EAGAIN ); -return ERR_PTR (-EDEADLK ); +return ERR_PTR (-ENOBUFS ); }int __i915_vma_pin_fence (struct i915_vma *vma)
Signature · 1 line
2.31.1
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Fix -EDEADLK handling regression
== Series Details ==
== Series Details ==
Series: drm/i915/gt: Fix -EDEADLK handling regression
URL : https://patchwork.freedesktop.org/series/92082/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20497
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/index.html
Known issues
------------
Here are the changes found in Patchwork_20497 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@nop-compute0:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/fi-kbl-soraka/igt@amdgpu/[email protected]
* igt@i915_module_load@reload:
- fi-kbl-soraka: [PASS][2] -> [DMESG-WARN][3] ([i915#1982])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/fi-kbl-soraka/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/fi-kbl-soraka/igt@[email protected]
* igt@runner@aborted:
- fi-bdw-5557u: NOTRUN -> [FAIL][4] ([i915#1602] / [i915#2029])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/fi-bdw-5557u/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
Participating hosts (39 -> 36)
------------------------------
Missing (3): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_10295 -> Patchwork_20497
CI-20190529: 20190529
CI_DRM_10295: 683b7f160eb6993ccfc19e67e3c7111f12946bea @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6124: 357d5477c93f2bdd3354afe91b89ccfd4ee4fd56 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20497: 222d1bd6e1e767781b7db298e0ff45379f78a61d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
222d1bd6e1e7 drm/i915/gt: Fix -EDEADLK handling regression
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Fix -EDEADLK handling regression
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915/gt: Fix -EDEADLK handling regression
URL : https://patchwork.freedesktop.org/series/92082/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10295_full -> Patchwork_20497_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20497_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_20497_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20497_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@gem_exec_fair@basic-throttle@rcs0:
- {shard-rkl}: NOTRUN -> [FAIL][2] +15 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@gem_exec_fair@[email protected]
* igt@i915_pm_dc@dc6-psr:
- {shard-rkl}: [FAIL][3] ([i915#2951]) -> [SKIP][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- {shard-rkl}: NOTRUN -> [SKIP][5] +61 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs:
- {shard-rkl}: [PASS][6] -> [FAIL][7] +5 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-yf_tiled_ccs:
- {shard-rkl}: [FAIL][8] -> [SKIP][9] +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@kms_ccs@pipe-a-crc-primary-rotation-180-yf_tiled_ccs.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-6/igt@kms_ccs@pipe-a-crc-primary-rotation-180-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs:
- {shard-rkl}: [SKIP][10] -> [FAIL][11] +10 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs.html
* igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs:
- {shard-rkl}: [SKIP][12] ([i915#533]) -> [FAIL][13] +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs.html
* igt@kms_content_protection@atomic:
- {shard-rkl}: [SKIP][14] ([fdo#109300]) -> [SKIP][15] +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@[email protected]
* igt@kms_content_protection@dp-mst-type-0:
- {shard-rkl}: [SKIP][16] ([i915#3116]) -> [SKIP][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-32x10-onscreen:
- {shard-rkl}: [SKIP][18] ([i915#3359]) -> [SKIP][19] +4 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-128x42-random:
- {shard-rkl}: [SKIP][20] ([fdo#112022]) -> [SKIP][21] +14 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-2/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-32x32-offscreen:
- {shard-rkl}: [SKIP][22] ([i915#3319]) -> [SKIP][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled:
- {shard-rkl}: [SKIP][24] ([fdo#111314]) -> [SKIP][25] +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-2/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
- {shard-rkl}: [INCOMPLETE][26] -> [SKIP][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-6/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile:
- {shard-rkl}: NOTRUN -> [INCOMPLETE][28]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile:
- {shard-rkl}: [SKIP][29] -> [INCOMPLETE][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack-mmap-gtt:
- {shard-rkl}: [SKIP][31] ([fdo#111825]) -> [SKIP][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt:
- {shard-rkl}: [SKIP][33] ([fdo#111825] / [i915#1825]) -> [SKIP][34] +7 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt:
- {shard-rkl}: [SKIP][35] ([i915#1849]) -> [SKIP][36] +54 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- {shard-rkl}: [PASS][37] -> [SKIP][38] +40 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
- {shard-rkl}: [SKIP][39] ([i915#658]) -> [SKIP][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-6/igt@[email protected]
* igt@kms_psr@psr2_primary_render:
- {shard-rkl}: [FAIL][41] ([i915#132]) -> [SKIP][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_psr@psr2_primary_render.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_psr@psr2_primary_render.html
* igt@kms_psr@sprite_mmap_cpu:
- {shard-rkl}: [SKIP][43] ([i915#1072]) -> [SKIP][44] +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-2/igt@kms_psr@sprite_mmap_cpu.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_psr@sprite_mmap_cpu.html
Known issues
------------
Here are the changes found in Patchwork_20497_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-snb: NOTRUN -> [DMESG-WARN][45] ([i915#3002])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-snb7/igt@[email protected]
- shard-apl: NOTRUN -> [DMESG-WARN][46] ([i915#3002])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl1/igt@[email protected]
* igt@gem_ctx_isolation@preservation-s3@vecs0:
- shard-apl: NOTRUN -> [DMESG-WARN][47] ([i915#180])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl1/igt@gem_ctx_isolation@[email protected]
* igt@gem_ctx_persistence@legacy-engines-hostile-preempt:
- shard-snb: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#1099]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-snb6/igt@[email protected]
* igt@gem_ctx_sseu@engines:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#280])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][50] -> [TIMEOUT][51] ([i915#2369] / [i915#3063] / [i915#3648])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-tglb7/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb5/igt@[email protected]
- shard-snb: NOTRUN -> [FAIL][52] ([i915#3354])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-snb7/igt@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: NOTRUN -> [FAIL][53] ([i915#2842])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][54] -> [FAIL][55] ([i915#2842]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-tglb3/igt@gem_exec_fair@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [PASS][56] -> [SKIP][57] ([fdo#109271])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl1/igt@gem_exec_fair@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][58] -> [FAIL][59] ([i915#2849])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb8/igt@gem_exec_fair@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-iclb5/igt@gem_exec_fair@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2190])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl1/igt@[email protected]
* igt@gem_mmap_gtt@big-copy-odd:
- shard-glk: [PASS][61] -> [FAIL][62] ([i915#307])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk9/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk2/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-apl: NOTRUN -> [WARN][63] ([i915#2658])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl7/igt@[email protected]
* igt@gem_userptr_blits@coherency-sync:
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#110542])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#3323])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl3/igt@[email protected]
* igt@gem_userptr_blits@vma-merge:
- shard-glk: NOTRUN -> [FAIL][66] ([i915#3318])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk6/igt@[email protected]
* igt@gen7_exec_parse@oacontrol-tracking:
- shard-glk: NOTRUN -> [SKIP][67] ([fdo#109271]) +40 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk6/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-tglb: NOTRUN -> [SKIP][68] ([fdo#112306])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@[email protected]
* igt@i915_suspend@sysfs-reader:
- shard-skl: [PASS][69] -> [INCOMPLETE][70] ([i915#146] / [i915#198])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl5/igt@[email protected]
* igt@kms_big_fb@linear-16bpp-rotate-90:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271]) +215 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl3/igt@[email protected]
* igt@kms_big_fb@yf-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#111615]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@[email protected]
* igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#3689]) +3 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs.html
* igt@kms_chamelium@hdmi-edid-read:
- shard-snb: NOTRUN -> [SKIP][74] ([fdo#109271] / [fdo#111827]) +15 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-snb7/igt@[email protected]
* igt@kms_chamelium@hdmi-mode-timings:
- shard-kbl: NOTRUN -> [SKIP][75] ([fdo#109271] / [fdo#111827]) +20 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl6/igt@[email protected]
* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-glk: NOTRUN -> [SKIP][76] ([fdo#109271] / [fdo#111827]) +3 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk6/igt@[email protected]
* igt@kms_color@pipe-c-ctm-0-25:
- shard-skl: [PASS][77] -> [DMESG-WARN][78] ([i915#1982])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl2/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl3/igt@[email protected]
* igt@kms_color_chamelium@pipe-b-degamma:
- shard-tglb: NOTRUN -> [SKIP][79] ([fdo#109284] / [fdo#111827]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-ctm-0-25:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [fdo#111827]) +21 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl1/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-degamma:
- shard-skl: NOTRUN -> [SKIP][81] ([fdo#109271] / [fdo#111827]) +4 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl6/igt@[email protected]
* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> [TIMEOUT][82] ([i915#1319]) +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl1/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-32x32-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#3319])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-suspend:
- shard-kbl: NOTRUN -> [SKIP][84] ([fdo#109271]) +241 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl3/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-snb: NOTRUN -> [SKIP][85] ([fdo#109271]) +252 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-snb7/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [PASS][86] -> [FAIL][87] ([i915#2346])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl1/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl5/igt@[email protected]
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-kbl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#533]) +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl6/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][89] -> [DMESG-WARN][90] ([i915#180]) +5 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl6/igt@kms_flip@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][91] -> [DMESG-WARN][92] ([i915#180])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-apl1/igt@kms_flip@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl2/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][93] ([fdo#111825]) +3 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#533])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl6/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-skl: [PASS][95] -> [INCOMPLETE][96] ([i915#198] / [i915#2828])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl9/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl1/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#533])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][98] -> [FAIL][99] ([fdo#108145] / [i915#265])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl5/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][100] ([fdo#108145] / [i915#265]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][101] ([fdo#108145] / [i915#265]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl1/igt@[email protected]
* igt@kms_plane_lowres@pipe-d-tiling-y:
- shard-tglb: NOTRUN -> [SKIP][102] ([i915#3536])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@[email protected]
* igt@kms_plane_lowres@pipe-d-tiling-yf:
- shard-skl: NOTRUN -> [SKIP][103] ([fdo#109271]) +49 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl6/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#658]) +4 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl7/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#658]) +5 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl7/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-glk: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#658])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk6/igt@[email protected]
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][107] -> [SKIP][108] ([fdo#109441]) +3 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-iclb4/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_psr@psr2_primary_blt:
- shard-tglb: NOTRUN -> [FAIL][109] ([i915#132] / [i915#3467])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@kms_psr@psr2_primary_blt.html
* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][110] ([fdo#109271] / [i915#2437]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl1/igt@[email protected]
* igt@kms_writeback@writeback-invalid-parameters:
- shard-skl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#2437])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl6/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][112] ([fdo#109271] / [i915#2437])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl1/igt@[email protected]
* igt@kms_writeback@writeback-pixel-formats:
- shard-glk: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#2437])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk6/igt@[email protected]
* igt@nouveau_crc@pipe-d-source-rg:
- shard-tglb: NOTRUN -> [SKIP][114] ([i915#2530])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@[email protected]
* igt@perf_pmu@rc6-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][115] ([i915#180])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl7/igt@[email protected]
* igt@prime_nv_api@i915_nv_import_vs_close:
- shard-tglb: NOTRUN -> [SKIP][116] ([fdo#109291])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@prime_nv_api@i915_nv_import_vs_close.html
* igt@sysfs_clients@fair-0:
- shard-apl: NOTRUN -> [SKIP][117] ([fdo#109271] / [i915#2994]) +2 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl6/igt@[email protected]
* igt@sysfs_clients@fair-3:
- shard-kbl: NOTRUN -> [SKIP][118] ([fdo#109271] / [i915#2994]) +3 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl1/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#2994])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl6/igt@[email protected]
#### Possible fixes ####
* igt@fbdev@read:
- {shard-rkl}: [SKIP][120] ([i915#2582]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-6/igt@[email protected]
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][122] ([i915#658]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb3/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-iclb2/igt@[email protected]
* igt@gem_ctx_isolation@preservation-s3@vecs0:
- shard-kbl: [DMESG-WARN][124] ([i915#180]) -> [PASS][125] +10 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl2/igt@gem_ctx_isolation@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl7/igt@gem_ctx_isolation@[email protected]
* igt@gem_eio@unwedge-stress:
- {shard-rkl}: [TIMEOUT][126] -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-6/igt@[email protected]
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [FAIL][128] ([i915#2842]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb5/igt@gem_exec_fair@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-iclb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [FAIL][130] ([i915#2842]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk1/igt@gem_exec_fair@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk1/igt@gem_exec_fair@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][132] ([i915#2190]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-tglb6/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb1/igt@[email protected]
* igt@gem_mmap_gtt@cpuset-medium-copy:
- {shard-rkl}: [FAIL][134] ([i915#2428]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-1/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- {shard-rkl}: [SKIP][136] ([fdo#109308]) -> [PASS][137] +1 similar issue
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@system-suspend-execbuf:
- {shard-rkl}: [FAIL][138] ([fdo#103375]) -> [PASS][139] +1 similar issue
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@[email protected]
* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- shard-glk: [DMESG-WARN][140] ([i915#118] / [i915#95]) -> [PASS][141] +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk3/igt@kms_big_fb@x-tiled-32bpp-r
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Op 30-06-2021 om 18:44 schreef Ville Syrjala:
Quoted 39 lines
From: Ville Syrjälä <[email protected]>
The conversion to ww mutexes failed to address the fence code which already returns
-EDEADLKwhen we run out of fences. Ww mutexes on the other hand treat-EDEADLKas an internal errno value indicating a need to restart the operation due to a deadlock. So now when the fence code returns-EDEADLKthe higher level code erroneously restarts everything instead of returning the error to userspace as is expected.To remedy this let's switch the fence code to use a different errno value for this.
-ENOBUFSseems like a semi-reasonable unique choice. Apart from igt the only user of this I could find is sna, and even there all we do is dump the current fence registers from debugfs into the X server log. So no user visible functionality is affected. If we really cared about preserving this we could of course convert back to-EDEADLKhigher up, but doesn't seem like that's worth the hassle here.Not quite sure which commit specifically broke this, but I'll just attribute it to the general gem ww mutex work.
Cc: [email protected]
Cc: Maarten Lankhorst <[email protected]>
Cc: Thomas Hellström <[email protected]>
Testcase: igt/gem_pread/exhaustion
Testcase: igt/gem_pwrite/basic-exhaustion
Testcase: igt/gem_fenced_exec_thrash/too-many-fencesFixes 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.")Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +0
-0
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt) · line 354
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +1
-1@@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt)if (intel_has_pending_fb_unpin (ggtt->vm.i915))return ERR_PTR (-EAGAIN ); -return ERR_PTR (-EDEADLK ); +return ERR_PTR (-ENOBUFS ); }int __i915_vma_pin_fence (struct i915_vma *vma)
Makes sense..
Is it a slightly more reent commit? Might probably be the part that converts execbuffer to use ww locks.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 47 lines · Maarten Lankhorst
Op 30-06-2021 om 18:44 schreef Ville Syrjala:
Quoted 46 lines
From: Ville Syrjälä <[email protected]>
The conversion to ww mutexes failed to address the fence code which already returns
-EDEADLKwhen we run out of fences. Ww mutexes on the other hand treat-EDEADLKas an internal errno value indicating a need to restart the operation due to a deadlock. So now when the fence code returns-EDEADLKthe higher level code erroneously restarts everything instead of returning the error to userspace as is expected.To remedy this let's switch the fence code to use a different errno value for this.
-ENOBUFSseems like a semi-reasonable unique choice. Apart from igt the only user of this I could find is sna, and even there all we do is dump the current fence registers from debugfs into the X server log. So no user visible functionality is affected. If we really cared about preserving this we could of course convert back to-EDEADLKhigher up, but doesn't seem like that's worth the hassle here.Not quite sure which commit specifically broke this, but I'll just attribute it to the general gem ww mutex work.
Cc: [email protected]
Cc: Maarten Lankhorst <[email protected]>
Cc: Thomas Hellström <[email protected]>
Testcase: igt/gem_pread/exhaustion
Testcase: igt/gem_pwrite/basic-exhaustion
Testcase: igt/gem_fenced_exec_thrash/too-many-fencesFixes 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.")Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +1
-1@@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt)if (intel_has_pending_fb_unpin (ggtt->vm.i915))return ERR_PTR (-EAGAIN ); -return ERR_PTR (-EDEADLK ); +return ERR_PTR (-ENOBUFS ); }
Quoted 7 lines
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt) · line 354
Quoted 1 line
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +0
-0int __i915_vma_pin_fence (struct i915_vma *vma)Makes sense..
Reviewed-by Maarten Lankhorst <[email protected]>Is it a slightly more reent commit? Might probably be the part that converts execbuffer to use ww locks.
No idea about the specific commit since I've not actually bisected it. It's just been bugging CI for quite a while now so figured I need to fix it.
Signature · 2 lines
Ville Syrjälä Intel
Quoted 47 lines · Maarten Lankhorst
Op 30-06-2021 om 18:44 schreef Ville Syrjala:
Quoted 46 lines
From: Ville Syrjälä <[email protected]>
The conversion to ww mutexes failed to address the fence code which already returns
-EDEADLKwhen we run out of fences. Ww mutexes on the other hand treat-EDEADLKas an internal errno value indicating a need to restart the operation due to a deadlock. So now when the fence code returns-EDEADLKthe higher level code erroneously restarts everything instead of returning the error to userspace as is expected.To remedy this let's switch the fence code to use a different errno value for this.
-ENOBUFSseems like a semi-reasonable unique choice. Apart from igt the only user of this I could find is sna, and even there all we do is dump the current fence registers from debugfs into the X server log. So no user visible functionality is affected. If we really cared about preserving this we could of course convert back to-EDEADLKhigher up, but doesn't seem like that's worth the hassle here.Not quite sure which commit specifically broke this, but I'll just attribute it to the general gem ww mutex work.
Cc: [email protected]
Cc: Maarten Lankhorst <[email protected]>
Cc: Thomas Hellström <[email protected]>
Testcase: igt/gem_pread/exhaustion
Testcase: igt/gem_pwrite/basic-exhaustion
Testcase: igt/gem_fenced_exec_thrash/too-many-fencesFixes 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.")Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +1
-1@@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt)if (intel_has_pending_fb_unpin (ggtt->vm.i915))return ERR_PTR (-EAGAIN ); -return ERR_PTR (-EDEADLK ); +return ERR_PTR (-ENOBUFS ); }
Quoted 7 lines
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt) · line 354
Quoted 1 line
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +0
-0int __i915_vma_pin_fence (struct i915_vma *vma)Makes sense..
Reviewed-by Maarten Lankhorst <[email protected]>Is it a slightly more reent commit? Might probably be the part that converts execbuffer to use ww locks.
- please cc: dri-devel on anything gem/gt related.
- this should probably be ENOSPC or something like that for at least a seeming retention of errno consistentcy:
https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-return-values
Cheers, Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Quoted 56 lines · Daniel Vetter
Quoted 53 lines · Maarten Lankhorst
Op 30-06-2021 om 18:44 schreef Ville Syrjala:
Quoted 39 lines
From: Ville Syrjälä <[email protected]>
The conversion to ww mutexes failed to address the fence code which already returns
-EDEADLKwhen we run out of fences. Ww mutexes on the other hand treat-EDEADLKas an internal errno value indicating a need to restart the operation due to a deadlock. So now when the fence code returns-EDEADLKthe higher level code erroneously restarts everything instead of returning the error to userspace as is expected.To remedy this let's switch the fence code to use a different errno value for this.
-ENOBUFSseems like a semi-reasonable unique choice. Apart from igt the only user of this I could find is sna, and even there all we do is dump the current fence registers from debugfs into the X server log. So no user visible functionality is affected. If we really cared about preserving this we could of course convert back to-EDEADLKhigher up, but doesn't seem like that's worth the hassle here.Not quite sure which commit specifically broke this, but I'll just attribute it to the general gem ww mutex work.
Cc: [email protected]
Cc: Maarten Lankhorst <[email protected]>
Cc: Thomas Hellström <[email protected]>
Testcase: igt/gem_pread/exhaustion
Testcase: igt/gem_pwrite/basic-exhaustion
Testcase: igt/gem_fenced_exec_thrash/too-many-fencesFixes 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.")Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +0
-0drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt) · line 354
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +1
-1@@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt)if (intel_has_pending_fb_unpin (ggtt->vm.i915))return ERR_PTR (-EAGAIN ); -return ERR_PTR (-EDEADLK ); +return ERR_PTR (-ENOBUFS ); }int __i915_vma_pin_fence (struct i915_vma *vma)Makes sense..
Reviewed-by Maarten Lankhorst <[email protected]>
Quoted 7 lines
Quoted 1 line
Is it a slightly more reent commit? Might probably be the part that converts execbuffer to use ww locks.
- please cc: dri-devel on anything gem/gt related.
- this should probably be ENOSPC or something like that for at least a seeming retention of errno consistentcy:https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-return-values
Other option would be to map that back to EDEADLK in the execbuf ioctl somewhere, so we retain a distinct errno code.
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Rodrigo Vivi
maintainerQuoted 59 lines · Daniel Vetter
Quoted 58 lines · Daniel Vetter
Quoted 54 lines · Maarten Lankhorst
Op 30-06-2021 om 18:44 schreef Ville Syrjala:
Quoted 39 lines
From: Ville Syrjälä <[email protected]>
The conversion to ww mutexes failed to address the fence code which already returns
-EDEADLKwhen we run out of fences. Ww mutexes on the other hand treat-EDEADLKas an internal errno value indicating a need to restart the operation due to a deadlock. So now when the fence code returns-EDEADLKthe higher level code erroneously restarts everything instead of returning the error to userspace as is expected.To remedy this let's switch the fence code to use a different errno value for this.
-ENOBUFSseems like a semi-reasonable unique choice. Apart from igt the only user of this I could find is sna, and even there all we do is dump the current fence registers from debugfs into the X server log. So no user visible functionality is affected. If we really cared about preserving this we could of course convert back to-EDEADLKhigher up, but doesn't seem like that's worth the hassle here.Not quite sure which commit specifically broke this, but I'll just attribute it to the general gem ww mutex work.
Cc: [email protected]
Cc: Maarten Lankhorst <[email protected]>
Cc: Thomas Hellström <[email protected]>
Testcase: igt/gem_pread/exhaustion
Testcase: igt/gem_pwrite/basic-exhaustion
Testcase: igt/gem_fenced_exec_thrash/too-many-fencesFixes 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.")Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +0
-0drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt) · line 354
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +1
-1@@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt)if (intel_has_pending_fb_unpin (ggtt->vm.i915))return ERR_PTR (-EAGAIN ); -return ERR_PTR (-EDEADLK ); +return ERR_PTR (-ENOBUFS ); }int __i915_vma_pin_fence (struct i915_vma *vma)Makes sense..
Reviewed-by Maarten Lankhorst <[email protected]>Is it a slightly more reent commit? Might probably be the part that converts execbuffer to use ww locks.
Quoted 8 lines
Quoted 5 lines
- please cc: dri-devel on anything gem/gt related.
- this should probably be ENOSPC or something like that for at least a seeming retention of errno consistentcy:https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-return-values
Other option would be to map that back to EDEADLK in the execbuf ioctl somewhere, so we retain a distinct errno code.
I'm about to push this patch to drm-intel-fixes... I'm assuming if there's any fix it will be a follow-up patch and not a revert or force push, right?!
Quoted 9 lines
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 55 lines · Daniel Vetter
Quoted 54 lines · Daniel Vetter
Quoted 51 lines · Maarten Lankhorst
Op 30-06-2021 om 18:44 schreef Ville Syrjala:
Quoted 39 lines
From: Ville Syrjälä <[email protected]>
The conversion to ww mutexes failed to address the fence code which already returns
-EDEADLKwhen we run out of fences. Ww mutexes on the other hand treat-EDEADLKas an internal errno value indicating a need to restart the operation due to a deadlock. So now when the fence code returns-EDEADLKthe higher level code erroneously restarts everything instead of returning the error to userspace as is expected.To remedy this let's switch the fence code to use a different errno value for this.
-ENOBUFSseems like a semi-reasonable unique choice. Apart from igt the only user of this I could find is sna, and even there all we do is dump the current fence registers from debugfs into the X server log. So no user visible functionality is affected. If we really cared about preserving this we could of course convert back to-EDEADLKhigher up, but doesn't seem like that's worth the hassle here.Not quite sure which commit specifically broke this, but I'll just attribute it to the general gem ww mutex work.
Cc: [email protected]
Cc: Maarten Lankhorst <[email protected]>
Cc: Thomas Hellström <[email protected]>
Testcase: igt/gem_pread/exhaustion
Testcase: igt/gem_pwrite/basic-exhaustion
Testcase: igt/gem_fenced_exec_thrash/too-many-fencesFixes 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.")Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +0
-0drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt) · line 354
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +1
-1@@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt)if (intel_has_pending_fb_unpin (ggtt->vm.i915))return ERR_PTR (-EAGAIN ); -return ERR_PTR (-EDEADLK ); +return ERR_PTR (-ENOBUFS ); }int __i915_vma_pin_fence (struct i915_vma *vma)Makes sense..
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
Reviewed-by Maarten Lankhorst <[email protected]>Is it a slightly more reent commit? Might probably be the part that converts execbuffer to use ww locks.
- please cc: dri-devel on anything gem/gt related.
Thought I did. Apparently got lost somewhere.
Quoted 2 lines
Quoted 2 lines
- this should probably be ENOSPC or something like that for at least a seeming retention of errno consistentcy:
ENOSPC is already used for other things.
Quoted 5 lines
Quoted 2 lines
https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-return-values
Other option would be to map that back to EDEADLK in the execbuf ioctl somewhere, so we retain a distinct errno code.
Already mentioned in the commit msg.
Signature · 2 lines
Ville Syrjälä Intel