i2c: ali1535: mention that the device should not be disabled
PATCH 1/1 i2c: ali1535: mention that the device should not be disabled
The comment from the i801 driver is valid here, too, so copy it.
Reported-by Jean Delvare <[email protected]>
Signed-off-by Wolfram Sang <[email protected]>
--- drivers/i2c/busses/i2c-ali1535.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/i2c/busses/i2c-ali1535.c +5 -0
@@ -508,6 +508,11 @@ static void ali1535_remove(struct pci_dev *dev) {i2c_del_adapter (&ali1535_adapter);release_region (ali1535_smba,ALI1535_SMB_IOSIZE ); + +/* +* do not call pci_disable_device(dev) since it can cause hard hangs on +* some systems during power-off +*/ }static struct pci_driver ali1535_driver = {
Signature · 1 line
2.30.2
Quoted 14 lines · Wolfram Sang
The comment from the i801 driver is valid here, too, so copy it.
Reported-by Jean Delvare <[email protected]>Signed-off-by Wolfram Sang <[email protected]>--- drivers/i2c/busses/i2c-ali1535.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/i2c/busses/i2c-ali1535.c +0
-0@@ -508,6 +508,11 @@ static void ali1535_remove(struct pci_dev *dev) {
drivers/i2c/busses/i2c-ali1535.c static void ali1535_remove(struct pci_dev *dev) · line 518
Quoted 10 lines
drivers/i2c/busses/i2c-ali1535.c +5
-0i2c_del_adapter (&ali1535_adapter);release_region (ali1535_smba,ALI1535_SMB_IOSIZE ); + +/* +* do not call pci_disable_device(dev) since it can cause hard hangs on +* some systems during power-off +*/ }static struct pci_driver ali1535_driver = {
Can't hurt.
Reviewed-by Jean Delvare <[email protected]>
Signature · 2 lines
Jean Delvare SUSE L3 Support
Wolfram Sang
AppliedQuoted 4 lines · Wolfram Sang
The comment from the i801 driver is valid here, too, so copy it.
Reported-by Jean Delvare <[email protected]>Signed-off-by Wolfram Sang <[email protected]>
Applied to for-current, thanks!